Skip to content

Conversation

@ElwinLiu
Copy link

@ElwinLiu ElwinLiu commented Jan 10, 2026

Summary

Fixed the sync skill loader to produce consistently wrapped templates matching the async loader.

Problem

The sync loader was setting template to an empty string, while the async loader properly wrapped it with and tags. This caused skills loaded via config-handler.ts to have empty templates.

Solution

  1. Create wrappedTemplate variable upfront with proper tags
  2. Use wrappedTemplate for both definition.template and lazyContent.load()
  3. Removed redundant file re-read in lazyContent.load()

Testing

  • bun run typecheck passes
  • bun run build succeeds

Summary by cubic

Fixes the sync skill loader so templates are wrapped with and , matching the async loader. Prevents empty templates when loading skills via config-handler.

  • Bug Fixes

    • Use a single wrapped template for definition.template and lazyContent.load() to keep behavior consistent.
  • Refactors

    • Remove redundant file read in lazyContent.load() by reusing the prepared wrapped template.

Written for commit c965ec6. Summary will update on new commits.

…loader

The sync loader was setting template to an empty string, while the async
loader properly wrapped it with <skill-instruction> and <user-request> tags.
This caused inconsistent behavior when skills were loaded through different
paths (config-handler vs main plugin).

Also removes redundant file re-read in lazyContent.load() by reusing the
same wrappedTemplate variable.
@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2026

All contributors have signed the CLA. Thank you! ✅
Posted by the CLA Assistant Lite bot.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@ElwinLiu
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant