From c4169f08a5557ff39cc6bd86a2593ce0c7049c43 Mon Sep 17 00:00:00 2001
From: "codeflash-ai[bot]"
 <148906541+codeflash-ai[bot]@users.noreply.github.com>
Date: Thu, 13 Nov 2025 03:25:26 +0000
Subject: [PATCH] Optimize find_first_non_return_key

The optimization replaces dictionary `.items()` iteration with direct key iteration, eliminating unnecessary tuple unpacking overhead.

**Key changes:**
- Changed `for key, value in some_dict.items():` to `for key in some_dict:`
- Changed `return value` to `return some_dict[key]`

**Why it's faster:**
1. **Eliminates tuple creation/unpacking**: `.items()` creates `(key, value)` tuples for each iteration, which must then be unpacked. Direct key iteration avoids this allocation overhead.
2. **Reduces function call overhead**: `.items()` is a method call that returns an iterator, while `some_dict` iteration uses Python's built-in iterator protocol more efficiently.
3. **Deferred value access**: The optimized version only accesses `some_dict[key]` when actually returning, not for every iteration.

**Performance impact:**
The line profiler shows the loop line improved from 93,776ns to 79,529ns (15% faster), contributing to the overall 42% speedup. Test results show consistent 20-66% improvements across all scenarios, with particularly strong gains (50%+) for cases with empty dicts, single keys, or early returns.

**Hot path impact:**
Based on the function reference, this optimization is valuable since `find_first_non_return_key` is called within `extract_docstrings()` during component documentation processing. The function processes method parameters for each component's preprocess/postprocess methods, meaning this optimization reduces overhead during Gradio's CLI documentation generation workflow.

**Best performance cases:**
The optimization excels when the first non-"return" key is found early (up to 66% faster for empty dicts), making it particularly effective for typical documentation processing where "return" keys are less common or appear later in parameter dictionaries.
---
 gradio/cli/commands/components/_docs_utils.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gradio/cli/commands/components/_docs_utils.py b/gradio/cli/commands/components/_docs_utils.py
index 76744f1b93..420f9f8fc5 100644
--- a/gradio/cli/commands/components/_docs_utils.py
+++ b/gradio/cli/commands/components/_docs_utils.py
@@ -9,9 +9,9 @@
 
 def find_first_non_return_key(some_dict):
     """Finds the first key in a dictionary that is not "return"."""
-    for key, value in some_dict.items():
+    for key in some_dict:
         if key != "return":
-            return value
+            return some_dict[key]
     return None