Fix issue accessing fields on Snippet class.

sheabunge · sheabunge · commit 67c129a124c9 · 2023-11-07T02:30:46.000+11:00
diff --git a/php/class-data-item.php b/php/class-data-item.php
@@ -204,7 +204,8 @@ public function get_allowed_fields(): array {
 	 * @return bool true if the is allowed, false if invalid.
 	 */
 	public function is_allowed_field( string $field ): bool {
-		return isset( $this->fields[ $field ] ) || isset( $this->field_aliases[ $field ] );
+		return $this->fields && array_key_exists( $field, $this->fields ) ||
+		       $this->field_aliases && array_key_exists( $field, $this->field_aliases );
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,8 @@ public function get_allowed_fields(): array {`
`204`	`204`	`* @return bool true if the is allowed, false if invalid.`
`205`	`205`	`*/`
`206`	`206`	`public function is_allowed_field( string $field ): bool {`
`207`		`- return isset( $this->fields[ $field ] ) \|\| isset( $this->field_aliases[ $field ] );`
	`207`	`+ return $this->fields && array_key_exists( $field, $this->fields ) \|\|`
	`208`	`+ $this->field_aliases && array_key_exists( $field, $this->field_aliases );`
`208`	`209`	`}`
`209`	`210`
`210`	`211`	`/**`