Prevent snippet from running twice when being checked for errors on save

Author: sheabunge

php/admin-menus/class-edit-menu.php

@@ -15,6 +15,10 @@ public function __construct() {
 		);
 
 		add_action( 'admin_init', array( $this, 'remove_incompatible_codemirror' ) );
+
+		if ( isset( $_POST['save_snippet'] ) && $_POST['save_snippet'] ) {
+			add_action( 'code_snippets/allow_execute_snippet', array( $this, 'prevent_exec_on_save' ), 10, 2 );
+		}
 	}
 
 	/**
@@ -35,6 +39,30 @@ public function register() {
 		}
 	}
 
+	/**
+	 * Prevent the snippet currently being saved from being executed
+	 * so it is not run twice (once normally, once
+	 *
+	 * @param bool $exec    Whether the snippet will be executed
+	 * @param int  $exec_id The ID of the snippet being executed
+	 *
+	 * @return bool Whether the snippet will be executed
+	 */
+	function prevent_exec_on_save( $exec, $exec_id ) {
+
+		if ( ! isset( $_POST['save_snippet'], $_POST['snippet_id'] ) ) {
+			return $exec;
+		}
+
+		$id = intval( $_POST['snippet_id'] );
+
+		if ( $id == $exec_id ) {
+			return false;
+		}
+
+		return $exec;
+	}
+
 	/**
 	 * Executed when the menu is loaded
 	 */
@@ -143,7 +171,7 @@ private function unshare_network_snippet( $snippet_id ) {
 	private function code_error_callback( $out ) {
 		$error = error_get_last();
 
-		if ( is_null( $error ) || ! in_array( $error['type'], array( E_ERROR, E_COMPILE_ERROR, E_USER_ERROR ) ) ) {
+		if ( is_null( $error ) ) {
 			return $out;
 		}
 
@@ -170,11 +198,6 @@ private function validate_code( Snippet $snippet ) {
 			return false;
 		}
 
-		/* Skip snippets that contain named functions */
-		if ( preg_match( '/(?:function|class)\s+\w+/i', $snippet->code ) ) {
-			return false;
-		}
-
 		ob_start( array( $this, 'code_error_callback' ) );
 		$result = eval( $snippet->code );
 		ob_end_clean();