Preserve snippet code_error in REST responses and show error notices

Author: CarolinaOP

src/js/hooks/useSubmitSnippet.ts

@@ -86,7 +86,7 @@ export const useSubmitSnippet = (): UseSubmitSnippet => {
 	const submitSnippet = useCallback(async (action: SubmitSnippetAction = SubmitSnippetAction.SAVE) => {
 		setCurrentNotice(undefined)
 
-		const result = await (async (): Promise<Snippet | string | undefined> => {
+		const rawResult = await (async (): Promise<Snippet | string | undefined> => {
 			try {
 				const request: Snippet = { ...snippet, ...SUBMIT_ACTION_DELTA[action] }
 				const response = await (0 === request.id ? snippetsAPI.create(request) : snippetsAPI.update(request))
@@ -100,25 +100,38 @@ export const useSubmitSnippet = (): UseSubmitSnippet => {
 
 		const messages = isCondition(snippet) ? conditionMessages : snippetMessages
 
-		if (undefined === result || 'string' === typeof result) {
+		if (undefined === rawResult || 'string' === typeof rawResult) {
 			const message = [
 				snippet.id ? messages.failedUpdate : messages.failedCreate,
-				result ?? __('The server did not send a valid response.', 'code-snippets')
+				rawResult ?? __('The server did not send a valid response.', 'code-snippets')
 			]
 
 			setCurrentNotice(['error', message.filter(Boolean).join(' ')])
 			return undefined
-		} else {
-			setSnippet(createSnippetObject(result))
-			setCurrentNotice(['updated', getSuccessNotice(snippet, result, action)])
+		}
 
-			if (snippet.id && result.id) {
-				window.document.title = window.document.title.replace(snippetMessages.addNew, messages.edit)
-				window.history.replaceState({}, '', addQueryArgs(window.CODE_SNIPPETS?.urls.edit, { id: result.id }))
-			}
+		const updatedSnippet = createSnippetObject(rawResult)
+		setSnippet(updatedSnippet)
 
-			return result
+		if (updatedSnippet.code_error) {
+			setCurrentNotice([
+				'error',
+				__('Snippet could not be activated because the code contains an error. See details below.', 'code-snippets')
+			])
+		} else {
+			setCurrentNotice(['updated', getSuccessNotice(snippet, updatedSnippet, action)])
 		}
+
+		if (snippet.id && updatedSnippet.id) {
+			window.document.title = window.document.title.replace(snippetMessages.addNew, messages.edit)
+			window.history.replaceState(
+				{},
+				'',
+				addQueryArgs(window.CODE_SNIPPETS?.urls.edit, { id: updatedSnippet.id })
+			)
+		}
+
+		return updatedSnippet
 	}, [snippetsAPI, setIsWorking, setCurrentNotice, snippet, setSnippet])
 
 	return { submitSnippet }

src/js/utils/snippets/objects.ts

@@ -13,7 +13,8 @@ const defaults: Omit<Snippet, 'tags'> = {
 	network: isNetworkAdmin(),
 	shared_network: null,
 	priority: 10,
-	conditionId: 0
+	conditionId: 0,
+	code_error: null
 }
 
 const isAbsInt = (value: unknown): value is number =>
@@ -33,6 +34,15 @@ export const parseSnippetObject = (fields: unknown): Snippet => {
 		return result
 	}
 
+	const codeError =
+		'code_error' in fields &&
+		Array.isArray(fields.code_error) &&
+		2 === fields.code_error.length &&
+		'string' === typeof fields.code_error[0] &&
+		'number' === typeof fields.code_error[1]
+			? (fields.code_error as readonly [string, number])
+			: undefined
+
 	return {
 		...result,
 		...'id' in fields && isAbsInt(fields.id) && { id: fields.id },
@@ -46,6 +56,7 @@ export const parseSnippetObject = (fields: unknown): Snippet => {
 		...'network' in fields && 'boolean' === typeof fields.network && { network: fields.network },
 		...'shared_network' in fields && 'boolean' === typeof fields.shared_network && { shared_network: fields.shared_network },
 		...'priority' in fields && 'number' === typeof fields.priority && { priority: fields.priority },
-		...'condition_id' in fields && isAbsInt(fields.condition_id) && { conditionId: fields.condition_id }
+		...'condition_id' in fields && isAbsInt(fields.condition_id) && { conditionId: fields.condition_id },
+		...('code_error' in fields && { code_error: codeError ?? result.code_error })
 	}
 }

src/php/rest-api/class-snippets-rest-controller.php

@@ -325,12 +325,12 @@ public function update_item( $request ) {
 			);
 		}
 
-		$item = $this->prepare_item_for_database( $request, $snippet );
+		$item   = $this->prepare_item_for_database( $request, $snippet );
 		$result = save_snippet( $item );
 
 		if ( $result ) {
-			$request->set_param( 'id', $result->id );
-			return $this->get_item( $request );
+			$data = $this->prepare_item_for_response( $result, $request );
+			return rest_ensure_response( $data );
 		}
 
 		return new WP_Error(