From fb78ee7f407dead5879aca492ca92574714cd38c Mon Sep 17 00:00:00 2001 From: Joe Heth Date: Mon, 1 Dec 2014 15:25:16 -0500 Subject: [PATCH] Handle error when getting submission data. --- lib/formstack/form.rb | 5 +++++ lib/formstack/submission.rb | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/formstack/form.rb b/lib/formstack/form.rb index 5df70a0..2fdb30f 100644 --- a/lib/formstack/form.rb +++ b/lib/formstack/form.rb @@ -234,6 +234,11 @@ def values_for_submission_id(submission_id, include_hidden = false) # cache submission submission = instance_variable_get("@submission_#{submission_id}") submission ||= FormStack::Submission.find(submission_id) + + if submission[:status] == "error" + raise submission[:error] + end + instance_variable_set("@submission_#{submission_id}", submission) fields = self.data_fields diff --git a/lib/formstack/submission.rb b/lib/formstack/submission.rb index 7b191a1..495f0d1 100644 --- a/lib/formstack/submission.rb +++ b/lib/formstack/submission.rb @@ -2,7 +2,7 @@ module FormStack class Submission < HashAttributeClass def value_of(id) - data = self["data"] + data = self["data"] || [] data.each do |d| if d["field"].to_s == id.to_s return d["value"]