Replace java.net.URL/URI with Ktor Url for KMP compatibility #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhump
reviewed
Jan 6, 2026
Member
jhump
left a comment
jhump
left a comment
There was a problem hiding this comment.
@utamori, thanks for the PR!
Like the other one I commented on, some changes are needed to get the lint CI check green and to also make the DCO check green. The latter requires signing off on each commit. I put more details in remarks in your other PR (here).
I've also left two remarks -- one a tiny style nit, the other a request to improve the behavior (and add a test) in code that you had to refactor.
library/src/main/kotlin/com/connectrpc/protocols/ConnectInterceptor.kt
Outdated
Show resolved
Hide resolved
utamori
force-pushed
the
feat/kmp-phase3-ktor-url
branch
2 times, most recently
from
65f0b0f to
6645325
Compare
Member
|
@utamori, looks like this needs to be rebased now that your other PR has been merged. |
utamori
force-pushed
the
feat/kmp-phase3-ktor-url
branch
from
2beaf93 to
904901f
Compare
- Add io.ktor:ktor-http dependency (3.3.3) - Replace java.net.URL with io.ktor.http.Url in HTTPRequest - Replace java.net.URI with io.ktor.http.Url in ProtocolClientConfig - Update ProtocolClient to use Ktor URLBuilder - Update ConnectInterceptor to use Ktor URLBuilder - Add URL scheme validation (http/https only) for fail-fast behavior - Update okhttp module to convert Ktor Url to String for OkHttp This prepares for Kotlin Multiplatform support (Issue connectrpc#140). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: utamori <mori_yuta@retail-ai.jp>
utamori
force-pushed
the
feat/kmp-phase3-ktor-url
branch
from
904901f to
77b8583
Compare
jhump
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
io.ktor:ktor-httpdependency (3.3.3)java.net.URLwithio.ktor.http.Urlin HTTPRequestjava.net.URIwithio.ktor.http.Urlin ProtocolClientConfigThis prepares for Kotlin Multiplatform support (Issue #140).
Behavioral Notes
xhtp://) now throwIllegalArgumentExceptionat config creation time (fail-fast), instead ofMalformedURLExceptionat first RPC callTest plan
🤖 Generated with Claude Code