You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on May 15, 2020. It is now read-only.
Important: I believe that the oracle signature should be enforced by the contract (only participants are, see here), otherwise there is no real enforcement that the rate should be provided by an oracle, a contractor can write a different version of the IssueInvoiceFlow where they provide any rate that they like.
In addition to that, what's the point of supplying the oracle as an attribute in the state (see here), and what's the point of using an oracle in this example if the contract is not taking advantage of that?
The flow shouldn't collect the signature of the oracle using CollectSignaturesFlow (see here), it already did that here.
The oracle shouldn't receive the finalized transaction (see here); it's not a participant in the state (see here), and at the end of the day, it's just an oracle.