Skip to content
This repository was archived by the owner on May 15, 2020. It is now read-only.
This repository was archived by the owner on May 15, 2020. It is now read-only.

Timesheet-example has multiple mistakes #108

@adelrustum

Description

@adelrustum

InvoiceContract:

  1. Important: I believe that the oracle signature should be enforced by the contract (only participants are, see here), otherwise there is no real enforcement that the rate should be provided by an oracle, a contractor can write a different version of the IssueInvoiceFlow where they provide any rate that they like.
    In addition to that, what's the point of supplying the oracle as an attribute in the state (see here), and what's the point of using an oracle in this example if the contract is not taking advantage of that?

  2. Typo here (probably copied from IOU example).

IssueInvoiceFlow:

  1. The flow shouldn't collect the signature of the oracle using CollectSignaturesFlow (see here), it already did that here.
  2. The oracle shouldn't receive the finalized transaction (see here); it's not a participant in the state (see here), and at the end of the day, it's just an oracle.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions