*: Demote some assert! to debug_assert!

Also removes some assertions that were kind of iffy in cuda_gl. Mostly in a pitiful attempt to micro-optimize debug builds

Author: modeco80

crates/letsplay_av_ffmpeg/src/cuda_gl/safe.rs

@@ -31,11 +31,6 @@ impl MappedGraphicsResource {
     }
 
     pub fn get_mapped_array(&mut self) -> Result<cuda_sys::CUarray, cuda_result::DriverError> {
-        assert!(
-            !self.resource.is_null(),
-            "do not call GraphicsResource::get_mapped_array if no resource is actually registered"
-        );
-
         let mut array: cuda_sys::CUarray = std::ptr::null_mut();
 
         unsafe {
@@ -50,11 +45,6 @@ impl MappedGraphicsResource {
     pub fn get_device_pointer(
         &mut self,
     ) -> Result<cuda_sys::CUdeviceptr, cuda_result::DriverError> {
-        assert!(
-            !self.resource.is_null(),
-            "do not call GraphicsResource::get_mapped_array if no resource is actually registered"
-        );
-
         let mut array: cuda_sys::CUdeviceptr = 0;
         let mut size: usize = 0;
 
@@ -94,6 +84,8 @@ impl GraphicsResource {
 
     /// Maps this resource.
     pub fn map(&mut self) -> Result<MappedGraphicsResource, cuda_result::DriverError> {
+        assert!(self.is_registered(), "Must register a resource before calling GraphicsResource::map()");
+
         let mut res = MappedGraphicsResource::new(self.resource);
         res.map()?;
 
@@ -106,7 +98,7 @@ impl GraphicsResource {
         texture_kind: gl::types::GLuint,
     ) -> Result<(), cuda_result::DriverError> {
         // better to be safe than leak memory? idk.
-        if !self.resource.is_null() {
+        if self.is_registered() {
             self.unregister()?;
         }
 
@@ -124,10 +116,10 @@ impl GraphicsResource {
     }
 
     pub fn unregister(&mut self) -> Result<(), cuda_result::DriverError> {
-        assert!(
-            !self.resource.is_null(),
-            "do not call if no resource is actually registered"
-        );
+        // Don't need to unregister if nothing's actually registered
+        if !self.is_registered() {
+            return Ok(());
+        }
 
         unsafe {
             cuda_sys::lib()

crates/letsplay_core/src/alloc.rs

@@ -4,7 +4,7 @@ use std::alloc;
 /// Unlike a [Vec<_>], this can't grow,
 /// but is just as safe to use, and slightly more predictable.
 pub fn alloc_boxed_slice<T: Sized>(len: usize) -> Box<[T]> {
-	assert_ne!(len, 0, "length cannot be 0");
+	debug_assert_ne!(len, 0, "length cannot be 0");
 	let layout = alloc::Layout::array::<T>(len).expect("?");
 
 	let ptr = unsafe { alloc::alloc_zeroed(layout) as *mut T };

crates/letsplay_gpu/src/gl_framebuffer.rs

@@ -137,7 +137,7 @@ impl GlFramebuffer {
 	pub fn read_pixels(&self, buffer: &mut [u32], width: u32, height: u32) {
 		let _guard = self.bind();
 
-		assert_eq!(
+		debug_assert_eq!(
 			buffer.len(),
 			(width * height) as usize,
 			"Provided buffer cannot hold the framebuffer"

crates/letsplay_gpu/src/lib.rs

@@ -47,7 +47,7 @@ pub mod egl_helpers {
 		// If it does your video drivers are more than likely broken beyond repair.
 		unsafe {
 			let extensions_ptr = QueryString(display, EXTENSIONS as i32);
-			assert!(!extensions_ptr.is_null());
+			debug_assert!(!extensions_ptr.is_null());
 
 			let extensions_str = std::ffi::CStr::from_ptr(extensions_ptr)
 				.to_str()

crates/letsplay_retro_frontend/src/frontend/log.rs

@@ -7,10 +7,8 @@ use tracing::*;
 /// This recieves log messages from our C++ helper code, and pulls them out into Tracing messages.
 pub extern "C" fn letsplay_retro_frontend_log(level: LogLevel, buf: *const ffi::c_char) {
 	// SAFETY: The [buf] pointer is null-checked in the C++ helper code, and the helper
-	// will never call us if the pointer is null.
+	// will never call into Rust if the pointer happens to be null.
 	unsafe {
-		debug_assert!(!buf.is_null(), "This pointer should NEVER be null");
-
 		match ffi::CStr::from_ptr(buf).to_str() {
 			Ok(message) => match level {
 				LogLevel::Debug => {