refactor: minor InlineLInk optimizations

0xPearce · 0xPearce · commit fe0cd8f70d76 · 2025-12-19T16:32:07.000+01:00
diff --git a/packages/curve-ui-kit/src/shared/ui/InlineLink.tsx b/packages/curve-ui-kit/src/shared/ui/InlineLink.tsx
@@ -10,13 +10,12 @@ export const InlineLink = ({ href, children }: { href: string; children: React.R
   const isExternal = href.startsWith('http')
   return (
     <Link
-      component={isExternal ? Link : TanstackLink}
       sx={{ color: 'currentColor', '&:hover': { textDecoration: 'none' } }}
       href={href}
-      {...(isExternal && { target: '_blank', rel: 'noreferrer noopener' })}
+      {...(isExternal && { target: '_blank', rel: 'noreferrer noopener', component: TanstackLink })}
     >
       {children}
-      {isExternal && <ArrowTopRightIcon fontSize={'small'} sx={{ verticalAlign: 'bottom' }} />}
+      {isExternal && <ArrowTopRightIcon fontSize="small" sx={{ verticalAlign: 'bottom' }} />}
     </Link>
   )
 }

Original file line number	Diff line number	Diff line change
`@@ -10,13 +10,12 @@ export const InlineLink = ({ href, children }: { href: string; children: React.R`
`10`	`10`	`const isExternal = href.startsWith('http')`
`11`	`11`	`return (`
`12`	`12`	`<Link`
`13`		`- component={isExternal ? Link : TanstackLink}`
`14`	`13`	`sx={{ color: 'currentColor', '&:hover': { textDecoration: 'none' } }}`
`15`	`14`	`href={href}`
`16`		`- {...(isExternal && { target: '_blank', rel: 'noreferrer noopener' })}`
	`15`	`+ {...(isExternal && { target: '_blank', rel: 'noreferrer noopener', component: TanstackLink })}`
`17`	`16`	`>`
`18`	`17`	`{children}`
`19`		`- {isExternal && <ArrowTopRightIcon fontSize={'small'} sx={{ verticalAlign: 'bottom' }} />}`
	`18`	`+ {isExternal && <ArrowTopRightIcon fontSize="small" sx={{ verticalAlign: 'bottom' }} />}`
`20`	`19`	`</Link>`
`21`	`20`	`)`
`22`	`21`	`}`