Skip to content

GCP Issue 6 - Improve code quality #3

@cverges

Description

@cverges

Reported by legege, Nov 18, 2009
A basic list of things to do that would help to improve the quality of this
library:

  • Meaningful JavaDoc
  • Standard: code formating, avoid _ in method names, ...
  • Remove dead code and code that is no longer used (comments)
  • Package name: com.googlecode.expect4j
  • Avoid public/package attributes
  • Avoid utils class (ExpectUtils)

Nov 18, 2009 #1 legege
I've refactored this library to remove the dependency on the tcl library. Of course, this removes the Expect
script tcl execution feature.

I've also completed basic code quality improvements. There are still a lot to do (e.g. break down the expect
method in Expect4J.. this method is unreadable). Unit tests are not deterministic (sometimes fails), exactly like
the HEAD version.

If the community is interested, I can commit this into a branch.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions