Skip to content

Incompatibility with MAF addon 2.0.6.0 - dots in filenames converted to underscores #3

@GoogleCodeExporter

Description

@GoogleCodeExporter
What steps will reproduce the problem?
======================================

1. Fresh install of firefox (I use latest nightlies and Ive been having this 
since at least back to 12.x) with a new profile.

2. Install the "Mozilla Archive Format, with MHT and Faithful Save" (latest at 
the time of writing this is 2.0.6.0) addon from:

https://addons.mozilla.org/en-us/firefox/addon/mozilla-archive-format/

3. Install latest "Automatic Save Folder" addon either 1.0.4 from AMO:

https://addons.mozilla.org/En-us/firefox/addon/automatic-save-folder/

...or 1.0.5 beta 118 from the developer's website beta section:

http://asf.mangaheart.org/?menu=2&sub=2

What is the expected output? What do you see instead?
=====================================================

Go to the "Automatic Save Folder" page on AMO:

https://addons.mozilla.org/En-us/firefox/addon/automatic-save-folder/

Do not try to download the addon from the link available at the top of the 
page. Go to the bottom of the page and click the "Version Information" section. 
This will unfold the latest version of the addon along with a "+ Add to 
Firefox" green button. Instead of left-clicking the button (don't want to 
install the addon, but download its .xpi file instead), right-click and select 
"Save Link As..."

The filename suggested is "automatic_save_folder-1.0_4-fx.xpi" instead of 
"automatic_save_folder-1.0.4-fx.xpi" (notice the underscore instead of a dot in 
the version part of the filename)

This doesn't happen in all domains, but mozilla addons is where I notice it 
more often. It doesn't happen with all addons downloads either. What I know for 
sure is that for it to happen there need to be more than one dot (other than 
the one between the filename and the extension I mean) in the downloaded file 
name.

Disabling either one of the addons suggests the correct filename with the dot - 
no underscore ("automatic_save_folder-1.0.4-fx.xpi" for example). So, I guess 
it's not either addon's bug - it's an incompatibility between the two when both 
are installed together. Now, I don't know which addon's code is executed 
first/last or which one should be altered in order to not have this issue, so 
I'll file issues in both addons issue queues and hope for the best.

What version of ASF and Firefox are you using? On what operating system?
========================================================================

Tried both 1.0.4 and 1.0.5.0118 beta of ASF on firefox x64 nightlies under Win7 
x64.

I'm using this Firefox download option: Both Firefox download options have this 
issue

Please check the "View options when downloading" in ASF option tab, uncheck
"use same folder if same domain", download a file, and answer the following
questions :
ASF option box appear on the saving window? yes
The first suggested path is correct?
doesn't matter - this is done on a fresh profile - this happens even if no ASF 
filters defined yet - this is about the filename not the path
The file browser open on the wished folder?
doesn't matter - this is done on a fresh profile - this happens even if no ASF 
filters defined yet - this is about the filename not the browsed folder
If answer is no, which one opens ? last used


Is there any ASF report in the error console (Ctrl+Maj+J)?
==========================================================

statse.webtrendslive.com : server does not support RFC 5746, see CVE-2009-3555
-----------------------
Automatic Save Folder : 
These data will be used to verify the filters :
Filename:       automatic_save_folder-1.0.4-fx.xpi
Domain test order:  1,5
1 - File's domain:  https://addons.mozilla.org
2 - File's URL:     https://addons.mozilla.org/firefox/downloads/file/140995/
3 - Full file's 
URL:    https://addons.mozilla.org/firefox/downloads/file/140995/automatic_save_fol
der-1.0.4-fx.xpi?src=dp-btn-version
4 - Page's domain:  https://addons.mozilla.org
5 - Page's 
URL:        https://addons.mozilla.org/En-us/firefox/addon/automatic-save-folder/
6 - Page's 
referrer:   https://addons.mozilla.org/En-us/firefox/addon/automatic-save-folder/v
ersions/
7 - Tab's URL 
content:    https://addons.mozilla.org/En-us/firefox/addon/automatic-save-folder/
-----------------------
Automatic Save Folder : 
Filter 0 matched domain type : 1
-----------------------
Automatic Save Folder : 
Filter 1 matched domain type : 1
-----------------------
Automatic Save Folder : 
Filter 4 matched domain type : 1
-----------------------
Automatic Save Folder : 
No filter matched both domain and filename. These data will be used instead :
Folder:     
%asf_d%:    addons.mozilla.org
%asf_f%:    automatic_save_folder-1.0.4-fx.xpi
-----------------------
Automatic Save Folder : 
save location changed to: [some-path-here-removed-for-privacy-reasons
-----------------------
addons.mozilla.org : server does not support RFC 5746, see CVE-2009-3555]

Original issue reported on code.google.com by klo...@gmail.com on 3 Aug 2012 at 12:45

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions