Skip to content

I would like to change the variable names in two things #6

@GoogleCodeExporter

Description

@GoogleCodeExporter
I've been doing a lot of experimenting with libactp over the last week and I 
think I found something that is a bit confusing and not in line with HeeksCNC:
The variable names 'toolcornerrad' and 'toolflatrad' don't really correspond to 
the same meaning in the HeeksCNC project CuttingTool.cpp file. 
I think that in libactp actp.settoolcornerrad is actually used for setting the 
radius (1/2 diameter of) the tool, while in HeeksCNC it is used for setting the 
radius on the end of a ball nose cutter (or also a bull nose cutter). I looked 
in the freesteel src code and the convention seems to be backwards in reference 
to the way we do it in Heekscnc as well.
I am thinking about changing the variable name in the python binding for 
libactp from 'toolcornerrad' to 'endmilldiameter' (and dividing the value in 
half) or something a little more obvious. 
If I'm wrong about this- someone let me know. 
Thanks,
Dan

Original issue reported on code.google.com by ddfalck2...@yahoo.com on 1 Sep 2010 at 4:11

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions