Add dapp key command to create wallets

[mbrock]

Issue by nanexcool
Thursday Mar 15, 2018 at 23:09 GMT
Originally opened as dapphub/dapp#86

---

dapp key --help

dapp key --keystore path (will prompt for password)

dapp key --keystore path --password file

default keystore ~/.ethereum/keystore

can be used with ETH_KEYSTORE and ETH_PASSWORD for seth compatibility

---

nanexcool included the following code: https://github.com/dapphub/dapp/pull/86/commits

[mbrock]

Comment by dbrock
Thursday Mar 15, 2018 at 23:31 GMT

---

Hmmmmm I don't know if this should be in dapp!!!!!!!!??????????

Also it would have to be dapp key new (or dapp new-key), not just dapp key I think??????

[mbrock]

Comment by nanexcool
Thursday Mar 15, 2018 at 23:42 GMT

---

Yeah... it should be in seth? Here it's easy because we already have geth. In seth we'd have to either add geth or create a tiny program like ethsign that uses geth library for wallet creation, or add that capability to ethsign since it's already included, or grab some javascript library that already does this like ethereumjs-wallet

[mbrock]

Comment by dbrock
Friday Mar 16, 2018 at 00:00 GMT

---

Yeah, I think the right answer is probably to either add this to ethsign or like you said make a new program that has this capability.

Or... maybe seth should also simply depend on geth itself?

I actually think for example dapp testnet might make more sense as seth testnet...

[mbrock]

Comment by dbrock
Friday Mar 16, 2018 at 00:02 GMT

---

What do you think @mbrock?

[mbrock]

Comment by mbrock
Friday Mar 16, 2018 at 06:51 GMT

---

Hmm, seth testnet seems reasonable to me, in a general spirit of "dapp minimalism".

The --nix-run thing in dapp is a bit weird and should probably be replaced with using normal Nix dependencies (so yeah, Seth would just depend on Geth, or the patched "Geth Unlimited" which deviates from consensus in allowing huge contracts e.g. for test suites).