-
Notifications
You must be signed in to change notification settings - Fork 2
Description
Currently the only way to create a wallet with this package is to already have a keyfile exported from https://wallet.pokt.network/ which is a third party hosted service, and is something we try to stray away from at all costs. But we also don't like to take the responsibility of generating keys on the device, but at least in this repo's current form, the address, pubkey, and privkey, and passphrase are all stored in plaintext on the disk in the container, the passphrase is plaintext on the UI under the config Tab, and you don't need anything else to backup the keyfile from the UI as well leaving security very low with this particular app, obviously securing your node physically and with strong passwords and access via VPN the risk is significantly mitigated, but it does turn our policy of not generating keys online on it's head, as we're asking users to use a clearnet webpage (there's no reason not to trust the Pokt Foundation but we try to build trustless systems so I have a few options.
- Instead of directing our users to https://wallet.pokt.network/ to create a keyfile to upload we can add the wallet app https://github.com/pokt-foundation/wallet as a service in the pokt container to keep generation open source on our end, and it doesn't leave the dappnode.
- Built into the Pokt-core software is the CLI and the node and account methods, we can add to our existing UI things like being able to send excess funds out of a wallet, or more to the point of how I began this issue, you can run
pocket accounts createvia the app, it will ask for a passphrase and create the account which can then be exported and backed up withpocket accounts export <address> --path <path>https://docs.pokt.network/node/setup/ has details on some of these most basica commands that we can use to expand capabilities of what you can do with your node including create and send from them using our UI not having to use the wallet tool - However the wallet tool is needed initially for accounts that aren't set up with the node yet, need to check if this is true for just one account, or for multiple accounts, but perhaps we use a combo of option 1 and option 2.
@mgarciate any input?
Obviously all the other issues adding features especially allowing for LeanPocket and non custodial staking, even the unstake function (it didnt work for me when i tested it on mainnet, its just sending a message not a transaction so we have to rewrite that so the unstake function is not looking for an input) as well as the self signing for addresses. will blow of the size of the UI. and well probably wanna add tabs on the top so we can keep it simple with all the functionality.