Skip to content
This repository was archived by the owner on Mar 16, 2020. It is now read-only.

Commit ad62722

Browse files
authored
Merge pull request #1099 from dart-atom/fix_tooltips
fix an exception with tooltips
2 parents 1991a0b + 8ed358d commit ad62722

File tree

6 files changed

+369
-733
lines changed

6 files changed

+369
-733
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# dartlang plugin changelog
22

3+
## 0.6.44
4+
- removed the experimental `hoverTooltip` option; this feature was never fully
5+
implemented
6+
37
## 0.6.43
48
- update for some changes to the flutter_tools daemon protocol
59

lib/impl/tooltip.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ import '../state.dart';
1414

1515
final Logger _logger = new Logger('atom.tooltip');
1616

17+
// TODO: This library is unused.
18+
1719
/// Controls the hover tooltip with type information feature, capable of
1820
/// installing the feature into every active .dart editor.
1921
class TooltipController implements Disposable {

lib/plugin.dart

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import 'package:atom/node/process.dart';
1414
import 'package:atom/node/shell.dart';
1515
import 'package:atom/utils/dependencies.dart';
1616
import 'package:atom/utils/disposable.dart';
17-
import 'package:atom_dartlang/impl/tooltip.dart';
1817
import 'package:logging/logging.dart';
1918

2019
import 'analysis/analysis_options.dart';
@@ -165,7 +164,6 @@ class AtomDartPackage extends AtomPackage {
165164
disposables.add(new NavigationHelper());
166165
disposables.add(new OrganizeFileManager());
167166
disposables.add(new OutlineController());
168-
disposables.add(new TooltipController());
169167
disposables.add(pubManager);
170168
disposables.add(runAppManager);
171169
disposables.add(new RefactoringHelper());
@@ -377,12 +375,6 @@ class AtomDartPackage extends AtomPackage {
377375
},
378376

379377
// experimental features
380-
'hoverTooltip': {
381-
'title': '[Experimental] Enable type information tooltip',
382-
'type': 'boolean',
383-
'default': false,
384-
'order': 13
385-
},
386378
// TODO(devoncarew): This option needs some debugging; see #931.
387379
'formatOnSave': {
388380
'title': '[Experimental] Format files on save',

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: atom_dartlang
2-
version: 0.6.43
2+
version: 0.6.44
33
description: A Dart plugin for Atom.
44
homepage: https://github.com/dart-atom/dartlang
55

web/entry.dart.js

Lines changed: 359 additions & 721 deletions
Large diffs are not rendered by default.

web/entry.dart.js.map

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)