fix: peer discovery and reputation usage #416
Description
There are few things we should fix/improve related to peer management:
- I think we currently don't really request/process the
Addr/AddrV2messages so we only end up with a very limited number of peers we try to connect to from the initial DNS lookup. We should ask every new peer for its peers and maintain a list of reliable peers. - We should probably also try to connect to random peers to test them / get more addresses from other peers this way to find reliable peers if we dont have any good in our current list?
- We currently don't penalise any peer for misbehaving or being unreliable. Like giving a peer a small bump when its request times out is probably a good idea to eventually get rid of unreliable peers to avoid running constantly into timed out responses. Its probably also a good idea to let peers recover from being unreliable, i.e. removing score after a while?
- Store the time we last connected successfully to a peer and also include it in the decision which peer to connect to?
There is already some reputation management code which can be used/adjusted for this.