Skip to content

Suggest to loosen the dependency on ludwig #21

@Agnes-U

Description

@Agnes-U

Dear developers,

Your project model-hosting-in-lambda-example requires "ludwig==0.2.2.4" in its dependency. After analyzing the source code, we found that the following versions of ludwig can also be suitable without affecting your project, i.e., ludwig 0.2.2.3, 0.2.2.5, 0.2.2.6. Therefore, we suggest to loosen the dependency on ludwig from "ludwig==0.2.2.4" to "ludwig>=0.2.2.3,<=0.2.2.6" to avoid any possible conflict for importing more packages or for downstream projects that may use ddos_script.

May I pull a request to further loosen the dependency on ludwig?

By the way, could you please tell us whether such dependency analysis may be potentially helpful for maintaining dependencies easier during your development?



Details:

Your project (commit id: a757abe) directly uses 1 APIs from package ludwig.

ludwig.api.LudwigModel.load

Beginning fromwhich, 60 functions are then indirectly called, including 27 ludwig's internal APIs and 33 outsider APIs as follows:

[/data-skeptic/model-hosting-in-lambda-example]
+--ludwig.api.LudwigModel.load
|      +--ludwig.models.model.load_model_and_definition
|      |      +--ludwig.utils.data_utils.load_json
|      |      |      +--json.load
|      |      +--os.path.join
|      |      +--ludwig.models.model.Model.load
|      |      |      +--os.path.join
|      |      |      +--ludwig.utils.data_utils.load_json
|      |      |      +--ludwig.models.model.Model.__init__
|      |      |      |      +--ludwig.models.model.Model.__build
|      |      |      |      |      +--tensorflow.compat.v1.reset_default_graph
|      |      |      |      |      +--tensorflow.Graph
|      |      |      |      |      +--tensorflow.compat.v1.set_random_seed
|      |      |      |      |      +--tensorflow.Variable
|      |      |      |      |      +--tensorflow.compat.v1.placeholder
|      |      |      |      |      +--ludwig.models.inputs.build_inputs
|      |      |      |      |      |      +--collections.OrderedDict
|      |      |      |      |      |      +--ludwig.utils.algorithms_utils.topological_sort_feature_dependencies
|      |      |      |      |      |      |      +--ludwig.utils.algorithms_utils.topological_sort
|      |      |      |      |      |      +--ludwig.models.inputs.build_single_input
|      |      |      |      |      |      |      +--tensorflow.compat.v1.variable_scope
|      |      |      |      |      |      |      +--ludwig.utils.misc.get_from_registry
|      |      |      |      |      |      |      +--tensorflow.identity
|      |      |      |      |      +--ludwig.models.outputs.build_outputs
|      |      |      |      |      |      +--ludwig.utils.algorithms_utils.topological_sort_feature_dependencies
|      |      |      |      |      |      +--collections.OrderedDict
|      |      |      |      |      |      +--ludwig.models.outputs.build_single_output
|      |      |      |      |      |      |      +--tensorflow.compat.v1.variable_scope
|      |      |      |      |      |      |      +--ludwig.utils.misc.get_from_registry
|      |      |      |      |      |      +--collections.OrderedDict.update
|      |      |      |      |      |      +--tensorflow.reduce_sum
|      |      |      |      |      |      +--tensorflow.stack
|      |      |      |      |      |      +--tensorflow.compat.v1.get_collection
|      |      |      |      |      |      +--tensorflow.constant
|      |      |      |      |      |      +--tensorflow.add_n
|      |      |      |      |      |      +--tensorflow.add
|      |      |      |      |      +--ludwig.models.modules.optimization_modules.optimize
|      |      |      |      |      |      +--tensorflow.compat.v1.train.exponential_decay
|      |      |      |      |      |      +--tensorflow.compat.v1.get_collection
|      |      |      |      |      |      +--tensorflow.compat.v1.variable_scope
|      |      |      |      |      |      +--ludwig.models.modules.optimization_modules.get_optimizer_fun
|      |      |      |      |      |      +--tensorflow.train.AdamOptimizer
|      |      |      |      |      |      +--tensorflow.clip_by_global_norm
|      |      |      |      |      |      +--tensorflow.assign
|      |      |      |      |      |      +--tensorflow.group
|      |      |      |      |      +--tensorflow.compat.v1.summary.scalar
|      |      |      |      |      +--tensorflow.compat.v1.summary.merge_all
|      |      |      |      |      +--tensorflow.compat.v1.global_variables_initializer
|      |      |      |      |      +--tensorflow.compat.v1.train.Saver
|      |      |      |      |      +--ludwig.models.combiners.get_build_combiner
|      |      |      |      |      |      +--ludwig.utils.misc.get_from_registry
|      |      |      +--ludwig.models.model.Model.initialize_session
|      |      |      |      +--tensorflow.compat.v1.Session
|      |      |      |      +--tensorflow.python.debug.LocalCLIDebugWrapperSession
|      |      |      |      +--ludwig.utils.tf_utils.get_tf_config
|      |      |      |      |      +--tensorflow.compat.v1.ConfigProto
|      |      |      |      |      +--tensorflow.compat.v1.GPUOptions
|      |      |      +--ludwig.models.model.Model.restore
|      +--ludwig.api.LudwigModel.__init__
|      |      +--ludwig.api.LudwigModel.set_logging_level
|      |      |      +--logging.getLogger
|      |      |      +--ludwig.globals.set_disable_progressbar
|      |      +--copy.deepcopy
|      |      +--ludwig.utils.defaults.merge_with_defaults
|      |      |      +--ludwig.utils.defaults._perform_sanity_checks
|      |      |      +--ludwig.utils.misc.merge_dict
|      |      |      |      +--copy.deepcopy
|      |      |      |      +--ludwig.utils.misc.merge_dict
|      |      |      +--ludwig.utils.misc.set_default_value
|      |      |      +--ludwig.utils.defaults.get_default_optimizer_params
|      |      |      +--ludwig.utils.misc.get_from_registry
|      |      +--yaml.safe_load
|      +--ludwig.data.preprocessing.load_metadata
|      |      +--ludwig.utils.data_utils.load_json
|      +--os.path.join

Since all these functions have not been changed between any version for package "ludwig" from [0.2.2.3, 0.2.2.5, 0.2.2.6] and 0.2.2.4. Therefore, we believe it is safe to loosen the corresponding dependency.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions