Documentation use deprecated `transaction.listener`

[Kevinrob]

Hi,

We try to implement correctly the new Transaction. subscribe method instead of deprecated transaction.listener.
But the doc is not updated with it:

val transaction = Transaction(mobileToken)
transaction.listener = this // this refers to Android's Activity
transaction.options.isTesting = true
transaction.options.useCertificatePinning = true
TransactionRegistry.startTransaction(this, transaction)

Do you have any example or sample project that use it?

[luiscosta]

Hello @Kevinrob,

You're right, we should update that outdated documentation.

Referring to the Android SDK reference:
https://datatrans.github.io/android-sdk/-datatrans%20-android%20-s-d-k/ch.datatrans.payment.api/-transaction/-companion/index.html

The Transaction.subscribe(...) should be called on the Activity.onCreate method for construction and reconstruction so that you don't lose the result even when there's a reconstruction.

You also need to use Transaction.unsubscribe(...) on the Activity.onDestroy method.

So, it would be like this, you call these methods on onCreate and onDestroy and then wherever you are doing that piece of code you shown from our documentation you should just do it like that but do not define the listener:

val transaction = Transaction(mobileToken)
transaction.options.isTesting = true
transaction.options.useCertificatePinning = true
TransactionRegistry.startTransaction(this, transaction)

In terms of lifecycle would be something like:

onCreate { Transaction.subscribe(...) }

"Wherever you call the SDK" { 
      val transaction = Transaction(mobileToken)
      transaction.options.isTesting = true
      transaction.options.useCertificatePinning = true
      TransactionRegistry.startTransaction(this, transaction)
}

onDestroy { Transaction.unsubscribe(...) }

Just remember that if you use this Transaction.subscribe you shouldn't use the transaction.listener.

I hope I was helpful.

Again, thank you for alerting us about the documentation.

[Kevinrob]

Thank you for your quick response!