Skip to content

fix: prevent massive resyncs when RPC returns stale block number #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vp993 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: prevent massive resyncs when RPC returns stale block number #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
682f336
fix: prevent massive resyncs when RPC returns stale block number
vp993 Jan 23, 2026
4ebb247
test: add test for stale RPC block range handling
vp993 Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 7 additions & 20 deletions debridge_node/src/modules/chain/scanning/services/AddNewEventsAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import { SubmissionProcessingService } from './SubmissionProcessingService';
import { TransformService } from './TransformService';
import { ProcessNewTransferResultStatusEnum } from '../enums/ProcessNewTransferResultStatusEnum';
import Contract from 'web3-eth-contract';
import { SubmissionEntity } from 'src/entities/SubmissionEntity';

@Injectable()
export class AddNewEventsAction {
Expand All @@ -21,8 +20,6 @@ export class AddNewEventsAction {
constructor(
@InjectRepository(SupportedChainEntity)
private readonly supportedChainRepository: Repository<SupportedChainEntity>,
@InjectRepository(SubmissionEntity)
private readonly submissionsRepository: Repository<SubmissionEntity>,
private readonly chainConfigService: ChainConfigService,
private readonly web3Service: Web3Service,
private readonly solanaReaderService: SolanaReaderService,
Expand Down Expand Up @@ -76,24 +73,14 @@ export class AddNewEventsAction {
logger.debug(`Getting events from block ${fromBlock} to ${toBlock} on ${supportedChain.network}`);

// Handle invalid block range (fromBlock > toBlock)
// This can happen when the RPC returns a stale block number due to load balancing,
// network issues, or node sync delays. We reset to toBlock to prevent massive resyncs.
if (fromBlock > toBlock) {
logger.error(`Invalid block range: fromBlock (${fromBlock}) > toBlock (${toBlock})`);

// Find the latest block number for the given chainId from the submissions repository
const lastEvent = await this.submissionsRepository.findOne({
where: { chainFrom: chainId },
order: { blockNumber: 'DESC' }, // Get the highest block number
});

const newLatestBlock = lastEvent?.blockNumber ?? toBlock;
if (!lastEvent) {
logger.warn(`No events found for chainId ${chainId}. Using toBlock (${toBlock}) as latest.`);
} else {
logger.debug(`Found last event block number: ${newLatestBlock} for chainId ${chainId}`);
}

await this.supportedChainRepository.update(chainId, { latestBlock: newLatestBlock });
logger.log(`Updated latestBlock for chainId ${chainId} to ${newLatestBlock}`);
logger.warn(
`Stale RPC response detected: fromBlock (${fromBlock}) > toBlock (${toBlock}). ` +
`Resetting latestBlock to ${toBlock} to prevent resync from old blocks.`
);
await this.supportedChainRepository.update(chainId, { latestBlock: toBlock });
return;
}

Expand Down
116 changes: 99 additions & 17 deletions debridge_node/src/modules/chain/scanning/services/tests/AddNewEventsAction.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { Web3Service } from '../../../../web3/services/Web3Service';
import { SolanaReaderService } from '../SolanaReaderService';
import { SubmissionProcessingService } from '../SubmissionProcessingService';
import { TransformService } from '../TransformService';
import { SubmissionEntity } from '../../../../../entities/SubmissionEntity';
import { getRepositoryToken } from '@nestjs/typeorm';
import { Test, TestingModule } from '@nestjs/testing';
import { SupportedChainEntity } from '../../../../../entities/SupportedChainEntity';
Expand Down Expand Up @@ -50,31 +49,17 @@ describe('AddNewEventsAction', () => {

const module: TestingModule = await Test.createTestingModule({
providers: [
{
provide: getRepositoryToken(SubmissionEntity),
useValue: {
find: async () => {
return [
{
submissionId: '123',
},
];
},
update: async () => {
return;
},
},
},
{
provide: getRepositoryToken(SupportedChainEntity),
useValue: {
findOne: async chainId => {
return {
chainId,
latestBlock: 0,
latestBlock: 98,
network: 'eth',
} as SupportedChainEntity;
},
update: jest.fn().mockResolvedValue({}),
},
},
ChainConfigService,
Expand Down Expand Up @@ -159,4 +144,101 @@ describe('AddNewEventsAction', () => {
);
expect(processMock).toBeCalledTimes(1);
});

describe('stale RPC response handling', () => {
let staleRpcService: AddNewEventsAction;
let staleWeb3;
let staleGetPastEventsMock;
let staleProcessMock;
let updateMock;

beforeEach(async () => {
staleProcessMock = jest.fn().mockResolvedValue({});
staleGetPastEventsMock = jest.fn().mockResolvedValue([]);
updateMock = jest.fn().mockResolvedValue({});

// Simulate stale RPC: getBlockNumber returns 100, but latestBlock in DB is 200
// This means fromBlock (200) > toBlock (99) after blockConfirmation
staleWeb3 = {
eth: {
setProvider: jest.fn().mockResolvedValue({}),
Contract: jest.fn().mockImplementation(() => {
return {
setProvider: jest.fn().mockResolvedValue({}),
getPastEvents: staleGetPastEventsMock,
};
}),
getBlockNumber: jest.fn().mockResolvedValue(100), // RPC returns block 100
},
};

const module: TestingModule = await Test.createTestingModule({
providers: [
{
provide: getRepositoryToken(SupportedChainEntity),
useValue: {
findOne: async () => {
return {
chainId: 1,
latestBlock: 200, // DB has synced to block 200 (ahead of RPC)
network: 'eth',
} as SupportedChainEntity;
},
update: updateMock,
},
},
{
provide: ChainConfigService,
useValue: {
get(chainId) {
return {
chainId,
isSolana: false,
maxBlockRange: 200,
blockConfirmation: 1,
debridgeAddr: 'debridgeAddr',
providers: 'providers',
};
},
},
},
{
provide: Web3Service,
useValue: {
web3HttpProvider: jest.fn().mockImplementation(() => staleWeb3),
},
},
{
provide: SolanaReaderService,
useValue: {
syncTransactions: jest.fn().mockResolvedValue({}),
},
},
{
provide: SubmissionProcessingService,
useValue: {
process: staleProcessMock,
},
},
TransformService,
AddNewEventsAction,
],
}).compile();
staleRpcService = module.get(AddNewEventsAction);
});

it('should reset latestBlock to toBlock when RPC returns stale block number', async () => {
await staleRpcService.action(1);

// Should NOT fetch events when fromBlock > toBlock
expect(staleGetPastEventsMock).not.toBeCalled();

// Should NOT process any submissions
expect(staleProcessMock).not.toBeCalled();

// Should update latestBlock to toBlock (99) to prevent massive resync
// toBlock = getBlockNumber(100) - blockConfirmation(1) = 99
expect(updateMock).toBeCalledWith(1, { latestBlock: 99 });
});
});
});