-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomersnotifierNotification logic (console, webhooks, and notifier orchestration)Notification logic (console, webhooks, and notifier orchestration)
Description
Make notifier chain resilient to webhook failures
--
Context
When my webhook endpoint hiccups, prw stops before printing the console notification, so I miss local updates entirely.
Repro
- Configure a webhook to a local server, then shut it down
- Run
prw runand trigger a notification; console output should still print
Problem
MultiNotifier.Notify returns on the first notifier error and short-circuits the rest. A failing webhook blocks the console notifier.
Expected behavior
Console output should always show up even if a webhook fails; errors are reported after all notifiers are attempted.
Scope / non-goals
- Don’t redesign notifier types or add new transports.
- Keep logging concise; no retry logic here.
Acceptance criteria
-
MultiNotifierruns all notifiers without short-circuiting; console executes first. - If any notifier fails, the first error is returned after trying all of them.
- A brief warning is logged per failing notifier.
- Tests cover mixed success/failure order and confirm console still runs.
Hints
internal/notify/notify.go holds MultiNotifier; add tests nearby. This is a friendly good-first-issue.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomersnotifierNotification logic (console, webhooks, and notifier orchestration)Notification logic (console, webhooks, and notifier orchestration)