Fatal error with custom helper chained else if nested to deep

[johannesdb]

@theodorejb Just tried your fork to see if the fix also handles nested custom helper if-else if statements.

I found this bug in LigthNCandy: zordius/lightncandy#313

I have a custom helper: IfEquals (actually using the demo code for a helper from your repo), but when if I do a custom helper chained else blocks that is nested to many other helpers (if's and a custom contains) I get a fatal error:
Fatal error: Uncaught Exception: Unexpect token {{/ifEquals}} ! Previous token {{#[if]}} is not closed

If I replace the {{else ifEquals expression}} with {{else}}{{ifEquals expression}} I do not get an error

[theodorejb]

@johannesdb Can you share the template that causes the error? This error only occurs for me if an {{#if}} block is incorrectly closed by {{/ifEquals}} rather than {{/if}}.

[johannesdb]

I can try. The code is quite long and the template is large...

But the syntax would be something like

{{#if}} {{#IfEquals var1 var2}} *output html* {{else IfEquals var3 var4}} *output html* {{else}} *output html* {{/if}}

But it happens when the "else ifEquals" is nested quite deep.

I have attached the template. It is returned as a json file.
detail-json.json

This version works.

Deep inside the template, there is the following snippet:

{{#ifEquals (getNested @root.templateOptions.taxSettings (concat ../. ".showAs")) "icon"}}
more code
{{else}}
{{#ifEquals (getNested @root.templateOptions.taxSettings (concat ../. ".showAs")) "icon_text"}}
more code
{{else}}
more code
{{/ifEquals}}
{{/ifEquals}}

That snippet only works this way. If I do a {{else ifEquals}} the render failes

I know that my template is big and nasty :-/ And minified. Which makes it difficult to debug and test. But the template is made up of the same parts repeated in different if's and each's. So a big part of the code is dublicated code. I did try using partials, but there is a hug performance hit with this many partials in handlebarsjs so I had to do it another way

[theodorejb]

What version of PHP Handlebars are you using? The template in your attached JSON file compiles without any error for me in PHP Handlebars 0.9.8.

[theodorejb]

Within your giant template, I can't find the exact snippet you are referencing, and it's not very clear what changes need to be made to reproduce the error. If you could please share a template which causes the error, that would be helpful.

[johannesdb]

Sorry for the late reply! I am using 0.9.8. I know - it is giant... :-/ I will see if I can make a simpler version with the error.

[johannesdb]

Hey,

finally got around to make a much smaller template where the error is present.

The template renders fine in handlebars.js.

But when I try to use the template in php, I get an error:

{
"code": "UG API error",
"message": "/home/ugdata/digitaldogme.udstillerguide.dk/wp-content/plugins/udstillerguide/vendor/devtheorem/php-handlebars/src/Handlebars.php line: 65: Unexpect token {{/ifEquals}} ! Previous token {{#[contains]}} is not closed\nUnexpect token {{/contains}} ! Previous token {{#[each]}} is not closed\nUnexpect token {{/each}} ! Previous token {{#[if]}} is not closed\nUnexpect token {{/if}} ! Previous token {{#[ifEquals]}} is not closed",
"data": {
"status": 500,
"trace": [
"/home/ugdata/digitaldogme.udstillerguide.dk/wp-content/plugins/udstillerguide/vendor/devtheorem/php-handlebars/src/Handlebars.php:30",
"/home/ugdata/digitaldogme.udstillerguide.dk/wp-content/plugins/udstillerguide/vendor/devtheorem/php-handlebars/src/Handlebars.php:17",
"/home/ugdata/digitaldogme.udstillerguide.dk/wp-content/plugins/udstillerguide/src/API/Handler/FetchDataAPI.php:182",
"/home/ugdata/digitaldogme.udstillerguide.dk/wp-content/plugins/udstillerguide/src/API/Routes.php:311",
"/home/ugdata/digitaldogme.udstillerguide.dk/wp-content/plugins/udstillerguide/src/API/Routes.php:322",
"/home/ugdata/digitaldogme.udstillerguide.dk/wp-content/plugins/udstillerguide/src/API/Routes.php:309",
"/home/ugdata/digitaldogme.udstillerguide.dk/wp-includes/rest-api/class-wp-rest-server.php:1292",
"/home/ugdata/digitaldogme.udstillerguide.dk/wp-includes/rest-api/class-wp-rest-server.php:1125",
"/home/ugdata/digitaldogme.udstillerguide.dk/wp-includes/rest-api/class-wp-rest-server.php:439",
"/home/ugdata/digitaldogme.udstillerguide.dk/wp-includes/rest-api.php:459",
"/home/ugdata/digitaldogme.udstillerguide.dk/wp-includes/class-wp-hook.php:324",
"/home/ugdata/digitaldogme.udstillerguide.dk/wp-includes/class-wp-hook.php:348",
"/home/ugdata/digitaldogme.udstillerguide.dk/wp-includes/plugin.php:565",
"/home/ugdata/digitaldogme.udstillerguide.dk/wp-includes/class-wp.php:418",
"/home/ugdata/digitaldogme.udstillerguide.dk/wp-includes/class-wp.php:818",
"/home/ugdata/digitaldogme.udstillerguide.dk/wp-includes/functions.php:1342",
"/home/ugdata/digitaldogme.udstillerguide.dk/wp-blog-header.php:16",
"/home/ugdata/digitaldogme.udstillerguide.dk/index.php:17"
]
}
}

template that fails.txt

Hopes this makes more sense!

The work around is in line 80 to make the "else ifequals" to a else and a new ifequals

Let me know if I can provide info or help in any way!

[theodorejb]

Thank you @johannesdb. When I try that template with Handlebars.js there is a compile error saying "if doesn't match contains - 31:27". This is because there is a missing {{/if}} closing tag before the {{/contains}} on line 101. However, when I fix this the template does indeed compile with Handlebars.js, but not PHP Handlebars.

Here's a simplified reproduction I made (works with Handlebars.js):

{{#ifEquals @root.item "foo"}}
    phooey
{{else ifEquals @root.item "bar"}}
    barry
{{else}}
    {{#if @root.item}}
        {{#ifEquals @root.item "fizz"}}
            fizzy
        {{else ifEquals @root.item "buzz"}}
            buzzy
        {{else}}
            no matches
        {{/ifEquals}}
    {{/if}}
{{/ifEquals}}

In PHP Handlebars this template causes the following compile errors:

Unexpect token {{/ifEquals}} ! Previous token {{#[if]}} is not closed
Unexpect token {{/if}} ! Previous token {{#[ifEquals]}} is not closed

I will need to investigate further to find the root cause.

[johannesdb]

The missing {{#if}} is most likely a manual error... I edited the template to make it more simple. But glad that you could replicate the error.

If I can help with anything please let me know!