Hide recipes that craft/contain disabled items

[lxly9]

Hello, i wanted to suggest a feature that would completely hide recipes from the book that contain or craft stacks that have the FeatureSet enabledFeatures boolean as true. Its a vanilla FeatureSet afaik and disabled interactions when in survival, hence its be really useful if the recipes were being hidden as well!

[dicedpixels]

Looking at the code, if a feature set is not available, any item or recipe (that contains an ingredient which is disabled by that feature set) will not be available. This includes the recipe book.

Do you have a different scenario in mind?

[lxly9]

weirdly enough i can still see recipes that contain said disabled items for example the sign family still contains the (charm ebony wood) whose featureset is disabled and is shown in the recipe book. might be a bug on my instance then though

[dicedpixels]

It appears that Charm's "Feature" concept is not based on vanilla. It's a custom implementation. Unfortunately, they have their own code to handle recipe book related stuff so essentially making it incompatible with mine.

I'm surprised neither are crashing.

Edit: Recipe hiding could be an interesting feature to have.

[lxly9]

oh, charm was just an example, natures spirit and generally any item that got disabled is still
showing. (but yeah charms a special case, mightve been a bad example). i have some time to further look at whats happening this evening, i can report back then🫡

[lxly9]

heya, ive just came around to finally test it again and yes, disabled recipes are still being shown in grouped entries and singular ones.

(would you also backport the newer changes to 1.21.1?)

[dicedpixels]

I'll look into this, but I really don't have time to backport changes, so it will only appear in the latest version.

@lxly9 How did you disable that specific item?

[lxly9]

i use a small mod i created to pass a tag into the FeatureSet enabledFeatures boolean. it works fine with having the items' interactions blocked, etc.

very sad to hear but understandable

[lxly9]

https://github.com/lxly9/item-disabler/blob/master/src/main/java/com/item_disabler/mixin/ItemMixin.java

[dicedpixels]

Ah but I don't think that way of disabling recipes is correct. For example, here's a fresh survival world, no other mods, a test mod with just that mixin (I'm returning false, so I'd expect no recipes to show up).

[lxly9]

sorry... i kinda forgot to reply before work.

i was pretty sure that recipes got disabled (since you cannot craft the disabled items anymore). might be my mistake lol.

recipe hiding would be a great addition then