WIP: Ongeki support - [opened]

[icex2]

In GitLab by @felix on Mar 23, 2020, 01:12

Merges ongeki -> master

This MR adds support for Ongeki and Ongeki Plus. This saves pretty much everything the game sends except for userSessionlogList, userRatingBaseBestList, and userRatingBaseHotList from UpsertUserAllApi as they are not requested back by the game in any other request. I assume the rating lists are used by Sega's web profile viewer interface since the game recalculates the rating based on the scores sent.

[icex2]

In GitLab by @felix on Mar 23, 2020, 01:13

added 13 commits

• b3d2ff6a - ongeki: Basic boot support
• 7ae489a9 - ongeki: Save support for release version
• 13f260ff - ongeki: Fix user preview showing dummy card
• 21a36f26 - ongeki: Fix recent rating causing SQL row read exception
• 145de79b - ongeki: Add stub for GetUserEventRanking
• e431e8a1 - ongeki: Implement ExtendLockTime
• b09e6e06 - ongeki: Add event ids for option data
• b2f72082 - ongeki: Return music ids only for NgMusic type
• 243b08c0 - ongeki: Return requesting user id in preview response
• ec6a59d2 - ongeki: Prevent recursive item calls if user has more than 600 items
• 8ff7fbe5 - ongeki: Added methods for Ongeki Plus boot
• da36e864 - ongeki: Stub methods required for Ongeki Plus profile load
• 1f4d21ae - ongeki: Add remaining Ongeki Plus APIs and database tables

Compare with previous version

[icex2]

In GitLab by @felix on Mar 23, 2020, 01:13

Rebased off of master instead of my Chunithm branch.

[icex2]

In GitLab by @felix on Mar 23, 2020, 01:13

unmarked as a Work In Progress

[icex2]

In GitLab by @felix on Mar 23, 2020, 01:14

If you prefer the commits be squashed, I can do that.

[icex2]

In GitLab by @felix on Mar 23, 2020, 01:16

...and I forgot to move the event IDs to a separate file.

[icex2]

In GitLab by @felix on Mar 23, 2020, 01:35

added 19 commits

• 1f4d21ae...74997786 - 5 commits from branch djhackers:master
• 9363137e - ongeki: Basic boot support
• 170a1139 - ongeki: Save support for release version
• c7773919 - ongeki: Fix user preview showing dummy card
• a834786c - ongeki: Fix recent rating causing SQL row read exception
• a8f57d4e - ongeki: Add stub for GetUserEventRanking
• d3779a2e - ongeki: Implement ExtendLockTime
• e1ffc5e8 - ongeki: Add event ids for option data
• d0c54006 - ongeki: Return music ids only for NgMusic type
• e91291e2 - ongeki: Return requesting user id in preview response
• c990ab77 - ongeki: Prevent recursive item calls if user has more than 600 items
• 0db954d4 - ongeki: Added methods for Ongeki Plus boot
• a06aab16 - ongeki: Stub methods required for Ongeki Plus profile load
• 22254139 - ongeki: Add remaining Ongeki Plus APIs and database tables
• ee7bfde1 - ongeki: Move event IDs to separate static file

Compare with previous version

[icex2]

In GitLab by @felix on Mar 23, 2020, 01:35

Rebased off master and moved event IDs to separate file under src/ongeki/static.

[icex2]

In GitLab by @felix on Mar 23, 2020, 08:48

Ok, I have a report that the maintenance fix does not work in some cases. Thank you @NeumPhis

[icex2]

In GitLab by @tau on Mar 28, 2020, 18:32

Commented on src/ongeki/proto/base.ts line 31

Is this something that we receive from the game client in practice? We may want to return Date | undefined and store invalid dates as SQL NULLs in the database, potentially.

[icex2]

In GitLab by @tau on Mar 28, 2020, 18:37

Commented on src/ongeki/proto/base.ts line 11

For future reference it looks like there's a new TypeScript feature that allows us to precisely map a model object field's type to a crushed JSON type:

microsoft/TypeScript#21316

(I didn't know about it beforehand, I did some offhand searching just now to try and find a solution)

[icex2]

In GitLab by @tau on Mar 28, 2020, 18:42

Commented on src/ongeki/request/getGameMessage.ts line 5

Nitpick: Advisory comments aren't necessary for booleans since Ongeki sends them in their native JSON representation. They're still useful for numbers and strings since numbers may or may not be floating-point and strings may hold dates etc.

[icex2]

In GitLab by @tau on Mar 28, 2020, 18:46

Commented on src/ongeki/handler/index.ts line 60

Is this also true of Ongeki?

[icex2]

In GitLab by @tau on Mar 28, 2020, 18:48

Commented on src/ongeki/handler/index.ts line 96

C&P oversight

[icex2]

In GitLab by @tau on Mar 28, 2020, 18:51

Commented on src/ongeki/handler/getGameSetting.ts line 11

Nitpick but date_fns could be used here (dependency is already present in package.json)

[icex2]

In GitLab by @tau on Mar 28, 2020, 20:06

Commented on src/ongeki/repo/userPlaylog.ts line 6

This C&P comment seems to be contradicted by the existence of the loadLatest() method below