Add Chunithm events for all versions - [opened]

[icex2]

In GitLab by @felix on Feb 10, 2021, 03:46

Merges chunithm-events -> master

This MR adds event definitions for all Chunithm versions between 1.00 and 1.41. Not sure if this is a good way to approach this, especially the giant switch statement or the special {VERSION} marker that is replaced via regex.

[icex2]

In GitLab by @felix on Feb 14, 2021, 01:36

added 3 commits

• f5552d7 - switchboard: Add version to Chunithm title server URL
• 9029134 - chunithm: Add support for version-aware handlers
• 955e2b8 - chunithm: Add events for all Chunithm versions

Compare with previous version

[icex2]

In GitLab by @felix on Feb 14, 2021, 01:37

I did a review of my own code again and noticed I forgot to fix the call to startupUri in src/allnet.ts to pass the version info along.

[icex2]

In GitLab by @felix on Feb 14, 2021, 01:37

Not sure if I should make version a required parameter.

[icex2]

In GitLab by @Mai on Feb 14, 2021, 06:21

Based on comments within !30 this does seem to remove legacy event support for those that play with 'omnimix' data.
I would like to propose this be considered giving neets who no-life this game more content to grind on

[icex2]

In GitLab by @felix on Feb 14, 2021, 06:22

I suggest that those omnimix builds have the always open flag set on each event.

<alwaysOpen>true</alwaysOpen>

[icex2]

In GitLab by @felix on Feb 14, 2021, 06:24

resolved all threads

[icex2]

In GitLab by @Mai on Feb 14, 2021, 06:25

I was assuming this might have been in the game xml data, but your edit did confirm that

[icex2]

In GitLab by @esterTion on Feb 14, 2021, 08:50

I suggest that those omnimix builds have the always open flag set on each event.

I suggest remove getGameEvent list at all and ask every player just alwaysOpen their needed events, so that everyone is more happy

[icex2]

In GitLab by @esterTion on Feb 14, 2021, 08:54

Just saying straight now, I don't like your changes made in this merge. It achieves nothing while breaks some players' need.

[icex2]

In GitLab by @GRIM.657 on Feb 14, 2021, 09:13

If it is removed, everyone is forced to edit their data, which seems not ideal. There are actually users who want to see each version of the game properly, and I think it makes sense for the server to facilitate this. If a user makes a custom omnimix using the option data system, they are already editing their data, and should go ahead and use alwaysOpen where necessary. But for a user who downloads clean data for a particular SDBT version, in my opinion the server should be able to properly respond with the expected events.

[icex2]

In GitLab by @esterTion on Feb 14, 2021, 09:17

But for a user who downloads clean data for a particular SDBT version, in my opinion the server should be able to properly respond with the expected events.

Still, for a clean data there's no difference between sending all events versus versioned events. It achieves nothing but breaks some players previous working setup

[icex2]

In GitLab by @GRIM.657 on Feb 14, 2021, 09:24

I think there was a situation encountered recently where sending all IDs caused the game to break, but I don't have the details.

[icex2]

In GitLab by @esterTion on Feb 14, 2021, 09:29

Oh, that must've been network buffer overflow. CHUNITHM have only 100kb buffer for decompressed data.
This previously affected player scores being lost after 315 charts played.
Mine event list with removed information event still have plenty of space left.

[icex2]

In GitLab by @GRIM.657 on Feb 14, 2021, 09:53

Oh yeah, that might have been the issue. I can't say for sure since I wasn't the one experiencing it but if that's true then removing the information events seems viable. But of course, one day there will be too many events and some sort of solution like this MR will be needed, and this seems like a reasonable way of doing it.

[icex2]

In GitLab by @BemaniWitch on Feb 14, 2021, 15:36

Why not add a new .env variable?
CHUNITHM_ALLEVENTS
if true, it will load a master omnimix list, could remove the information events to avoid having the buffer overflow. That way everyone is happy and the default will still be close to the real thing.