-
Notifications
You must be signed in to change notification settings - Fork 0
Description
Overview
Tests are extremely brittle as they exist right now. They are liable to break whenever Septa updates their data for the endpoints Septum is scraping. Some of that is to be expected, we are working with undocumented endpoints after all and Septa has no obligation to inform anyone of breaking changes.
With the above in mind however. Recently, all tests that contained station "Trenton" broke because septa changed that station's name to "Trenton Transit Center". I don't believe this should've broken the tests. For example, in a lot of the tests, we're checking if it is valid to go from one station to another in a given direction on a given line. The current implementation just uses a hard-coded combination that is known to work or to not work.
When testing /api/schedule for example, it would make sense to just pick two stations going in a given direction (/api/schedule/stations does this) and check to see if we can get schedules for them.
The above is just one example, I believe changes like this are possible for a lot of the other test cases as well.