Clarification re. "partial" implementation of skew and multiple sample rates

[drewsilcock]

Hi David, thanks for the useful library!

Would you be able to clarify the status of the "partial" implementation of the analog channel-specific skew and the multiple sample rates?

It seems from the code that while the skew is being read in from the cfg file, it isn't being used anywhere to calculate channel-specific timestamps via the timestamp + (sample_number - 1) * skew equation. Is this what is meant by "partial" implementation? If so, are there any plans to include the channel-specific skews? (I imagine it would require moving the timestamps from a global property to a channel-specific property.)

In terms of the multiple sample rates, from the code it looks like this is fully implemented - I can't see what edge cases wouldn't be correctly handled by the logic in the DatReader._get_time() method according to my understanding. Is there something I'm missing here?

Thanks in advance!

[dparrini]

Hi @drewsilcock , thanks for your support!

To give you a quick answer, I'd say that every feature that I don't have any test or example data is something that has no or partial implementation - just because I can't be so sure if it works as intended.

In the case of the channel's skew I didn't come with any test case for this to check how much work is needed but you're probably right that it might not require much.

As you suggested, a possible implementation is moving the global timestamp logic into a local/per channel one. I think I'll have some challenges developing the interface to create dataframes from comtrade data work with time per channel, but I agree that it's the solution.

If you have any comtrade file that has this feature and don't mind to share ("anonymizing" it, removing descriptions, names and unneeded channels and data), please let me know.

[drewsilcock]

Hi David, thanks for the quick response and the explanation.

I like the ethos that if it isn't fully tested, it isn't fully implemented - if only more people took this attitude!

I'm afraid I don't have any COMTRADE files with skews in but I'll be sure to let you know if I come across any.