Skip to content

fix: KPI card button styling with borders and shadows #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drifter089 merged 1 commit into from
Jan 9, 2026
Merged

fix: KPI card button styling with borders and shadows #364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions src/components/metric/kpi-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ export function KpiCard({
isOnCanvas && "border-primary/50 bg-primary/5",
)}
>
{/* Header row */}
<div className="flex items-center gap-3">
{enableDragDrop &&
(canDrag ? (
Expand All @@ -99,7 +98,7 @@ export function KpiCard({

<div
className={cn(
"h-9 w-1.5 shrink-0 rounded-full",
"h-9 w-1.5 shrink-0 rounded-sm",
getPlatformConfig(metric.integration?.providerId ?? "manual")
.bgColor,
)}
Expand Down Expand Up @@ -135,9 +134,9 @@ export function KpiCard({
teamId={teamId}
trigger={
<Button
variant="ghost"
variant="outline"
size="icon"
className="text-muted-foreground hover:text-foreground h-7 w-7 opacity-0 transition-all group-hover:opacity-100"
className="h-7 w-7 border opacity-0 shadow-sm transition-all group-hover:opacity-100"
onClick={(e) => e.stopPropagation()}
>
<Settings className="h-3.5 w-3.5" />
Expand All @@ -153,13 +152,13 @@ export function KpiCard({
<Tooltip>
<TooltipTrigger asChild>
<Button
variant="ghost"
variant="outline"
size="icon"
className={cn(
"h-7 w-7 transition-all",
"h-7 w-7 border shadow-sm transition-all",
isOnCanvas
? "text-primary bg-primary/10 opacity-100"
: "text-muted-foreground hover:text-foreground opacity-0 group-hover:opacity-100",
? "border-primary bg-primary/10 text-primary opacity-100"
: "opacity-0 group-hover:opacity-100",
)}
onClick={(e) => {
e.stopPropagation();
Expand All @@ -177,15 +176,13 @@ export function KpiCard({
</div>
</div>

{/* Progress section */}
{goalProgress && timeElapsedPercent !== null && (
<div className="mt-4 space-y-3">
<p className="text-muted-foreground text-[11px] font-medium tracking-wider uppercase">
{formatCadence(goalProgress.cadence)} Goal
</p>

<div className="space-y-2.5">
{/* Goal Progress */}
<div className="flex items-center gap-3">
<div className="bg-muted h-2 flex-1 overflow-hidden rounded-full">
<div
Expand All @@ -210,7 +207,6 @@ export function KpiCard({
</div>
</div>

{/* Time Progress */}
<div className="flex items-center gap-3">
<div className="bg-muted h-2 flex-1 overflow-hidden rounded-full">
<div
Expand All @@ -233,7 +229,6 @@ export function KpiCard({
</div>
)}

{/* No goal state */}
{!goalProgress && (
<div className="mt-4">
<div className="flex items-center gap-3">
Expand All @@ -245,7 +240,6 @@ export function KpiCard({
</div>
)}

{/* Role display */}
<div className="mt-3 flex items-center gap-1.5">
{roles.length > 0 ? (
<>
Expand Down