Calling the Accounts API list endpoint gives and Unhandled API exception

[hsaloiye]

Description

Calling the /accounts/v1/account/list endpoint via the
Accounts.php list_accounts() function returns an Unhandled API exception.

Expected Behavior

We should receive a list of all subaccounts associated with this account

Actual Behavior

This call returns an Unhandled API exception

Steps to Reproduce

1. Have a test account which has a parent account and at least one subaccount
2. Using this API Client, attempt to call the /accounts/v1/account/list endpoint via the list_accounts()

I suspect this issue will also occur for other endpoints which pass in an empty list in the request bod.

Workarounds

checking out an older version of this repo before commit #38 will work.

[mbish]

This may be an issue with an empty list being serialized as an empty JSON list rather than an empty JSON object. Since PHP doesn’t differentiate between lists and dicts while JSON does the choice of which type to use for an empty list is arbitrary and sometimes wrong. We use empty lists in many places in the PHP library which means this is either (a) applies to many of the API handlers, not just the one posted in the issue or (b) the hypothesis that this is caused by empty lists is incorrect or (c) the other handlers don’t mind the empty list being used instead of an object.

Here is some pointers on how to coax the PHP JSON serializer into using an object and not a list
https://stackoverflow.com/a/16665216
https://www.php.net/manual/en/class.arrayobject.php

Here is the empty parameter list

duo_api_php/src/Accounts.php

Line 15 in e754a13

$params = [];

We have evidence that everywhere the parameter list isn’t empty it is used with explicit associative indices