From e0f34c15b326b7fd786363bc5ac2b8c6f790d049 Mon Sep 17 00:00:00 2001 From: David Johnston Date: Mon, 6 Oct 2025 22:46:49 +1100 Subject: [PATCH 1/3] Fix the highlighting :| --- .../GithubPermalink/GithubPermalink.stories.tsx | 4 ++++ src/library/SyntaxHighlight/SyntaxHighlight.tsx | 2 +- src/library/utils/getLanguageFromPath.test.ts | 12 ++++++------ src/library/utils/getLanguageFromPath.ts | 6 ++++-- 4 files changed, 15 insertions(+), 9 deletions(-) diff --git a/src/library/GithubPermalink/GithubPermalink.stories.tsx b/src/library/GithubPermalink/GithubPermalink.stories.tsx index f2820aa..543bdb7 100644 --- a/src/library/GithubPermalink/GithubPermalink.stories.tsx +++ b/src/library/GithubPermalink/GithubPermalink.stories.tsx @@ -37,6 +37,10 @@ export const DifferentLanguages: Story = {

TSX

+

TSX2

+ + +

Docker file

diff --git a/src/library/SyntaxHighlight/SyntaxHighlight.tsx b/src/library/SyntaxHighlight/SyntaxHighlight.tsx index 5a1a8de..f460e9b 100644 --- a/src/library/SyntaxHighlight/SyntaxHighlight.tsx +++ b/src/library/SyntaxHighlight/SyntaxHighlight.tsx @@ -144,6 +144,6 @@ export function SyntaxHighlight(props: { }, []) - return {text} + return <>{text} } diff --git a/src/library/utils/getLanguageFromPath.test.ts b/src/library/utils/getLanguageFromPath.test.ts index e7165c8..b2b3aed 100644 --- a/src/library/utils/getLanguageFromPath.test.ts +++ b/src/library/utils/getLanguageFromPath.test.ts @@ -2,8 +2,8 @@ import { describe, it, expect } from 'vitest'; import { getLanguageFromPath } from './getLanguageFromPath'; describe('getLanguageFromPath', () => { - it('should return typescript for .tsx files', () => { - expect(getLanguageFromPath('ReactRenders3.tsx')).toBe('typescript'); + it('should return tsx for .tsx files', () => { + expect(getLanguageFromPath('ReactRenders3.tsx')).toBe('tsx'); }); it('should return typescript for .ts files', () => { @@ -14,8 +14,8 @@ describe('getLanguageFromPath', () => { expect(getLanguageFromPath('script.js')).toBe('javascript'); }); - it('should return javascript for .jsx files', () => { - expect(getLanguageFromPath('component.jsx')).toBe('javascript'); + it('should return jsx for .jsx files', () => { + expect(getLanguageFromPath('component.jsx')).toBe('jsx'); }); it('should return python for .py files', () => { @@ -59,11 +59,11 @@ describe('getLanguageFromPath', () => { }); it('should handle paths with multiple dots', () => { - expect(getLanguageFromPath('src/components/MyComponent.tsx')).toBe('typescript'); + expect(getLanguageFromPath('src/components/MyComponent.tsx')).toBe('tsx'); }); it('should handle case insensitive extensions', () => { - expect(getLanguageFromPath('Component.TSX')).toBe('typescript'); + expect(getLanguageFromPath('Component.TSX')).toBe('tsx'); expect(getLanguageFromPath('Script.JS')).toBe('javascript'); }); }); \ No newline at end of file diff --git a/src/library/utils/getLanguageFromPath.ts b/src/library/utils/getLanguageFromPath.ts index 4afca5f..b5f6451 100644 --- a/src/library/utils/getLanguageFromPath.ts +++ b/src/library/utils/getLanguageFromPath.ts @@ -8,13 +8,15 @@ export function getLanguageFromPath(filePath: string): AvailableLanguagesPrism { switch (extension) { case 'js': - case 'jsx': case 'mjs': case 'cjs': return 'javascript'; + case 'jsx': + return 'jsx'; case 'ts': - case 'tsx': return 'typescript'; + case 'tsx': + return 'tsx'; case 'py': case 'python': return 'python'; From a4666d4406a85a969c462f1f8a2170adcd4dc408 Mon Sep 17 00:00:00 2001 From: David Johnston Date: Mon, 6 Oct 2025 22:47:20 +1100 Subject: [PATCH 2/3] Fix highlighting in green-rice-exist changeset Fix the syntax highlighting issue in the changeset. --- .changeset/green-rice-exist.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/green-rice-exist.md diff --git a/.changeset/green-rice-exist.md b/.changeset/green-rice-exist.md new file mode 100644 index 0000000..dcc8d72 --- /dev/null +++ b/.changeset/green-rice-exist.md @@ -0,0 +1,5 @@ +--- +"react-github-permalink": patch +--- + +Fix the highlighting :| From 89a57043a34cceae6372cd8cacf032b00b153c68 Mon Sep 17 00:00:00 2001 From: David Johnston Date: Tue, 7 Oct 2025 09:21:27 +1100 Subject: [PATCH 3/3] Improve language detection for JSX and TSX --- .changeset/green-rice-exist.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/green-rice-exist.md b/.changeset/green-rice-exist.md index dcc8d72..c6b5589 100644 --- a/.changeset/green-rice-exist.md +++ b/.changeset/green-rice-exist.md @@ -2,4 +2,4 @@ "react-github-permalink": patch --- -Fix the highlighting :| +Make JSX and TSX be detected specifically as JSX and TSX languages.