Skip to content

Dev master #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
developer2agentcars wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Dev master #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
97ffd84
Include debit card logic
juan0alfonso0agentcars Nov 13, 2020
f83936a
Include debit card logic
juan0alfonso0agentcars Nov 13, 2020
d9327c1
Include debit card logic
juan0alfonso0agentcars Nov 13, 2020
b65ac1b
Include debit card logic
juan0alfonso0agentcars Nov 13, 2020
11147c1
remove unused line
juan0alfonso0agentcars Nov 13, 2020
a55068e
Merge pull request #1 from juankamilo/feature-debitcard
juankamilo Nov 17, 2020
29ea21a
Merge branch 'master' into feature-debitcard
juan0alfonso0agentcars Nov 17, 2020
91dfea0
fix test
juan0alfonso0agentcars Nov 17, 2020
4164c07
include debitCardModel helper test
juan0alfonso0agentcars Nov 17, 2020
abb1593
Merge pull request #2 from juankamilo/feature-debitcard
juankamilo Nov 17, 2020
bbcb8a0
Fixes test
juan0alfonso0agentcars Nov 17, 2020
685c878
Merge branch 'master' into feature-debitcard
juan0alfonso0agentcars Nov 17, 2020
bdb40d4
Merge pull request #3 from juankamilo/feature-debitcard
juankamilo Nov 17, 2020
ec76ef6
Merge branch 'master' of https://github.com/ebanx/benjamin into ebanx…
juanrenting Feb 7, 2022
32ac227
Merge branch 'ebanx-master' into dev-master
juanrenting Feb 7, 2022
8b27cd1
Se agrego el campo "expiration_time_in_seconds" en el request, esto p…
developer2agentcars Feb 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,483 changes: 410 additions & 1,073 deletions composer.lock
View file
Open in desktop

Large diffs are not rendered by default.

47 changes: 47 additions & 0 deletions src/Models/DebitCard.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
<?php

namespace Ebanx\Benjamin\Models;

class DebitCard extends BaseModel
{

/**
* If a previously created token is informed,
* no credit card information is needed.
*
* @var string
*/
public $token;

/**
* Card brand.
*
* @var string
*/
public $type;

/**
* @var string
*/
public $threedsEci;

/**
* @var string
*/
public $threedsCryptogram;

/**
* @var string
*/
public $threedsXid;

/**
* @var string
*/
public $threedsVersion;

/**
* @var string
*/
public $threedsTrxid;
}
15 changes: 15 additions & 0 deletions src/Models/Payment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,14 @@ class Payment extends BaseModel
*/
public $card = null;

#CARD
/**
* A Debit Card object.
*
* @var DebitCard
*/
public $debit_card = null;

/**
* Extra information for reports.
*
Expand All @@ -143,4 +151,11 @@ class Payment extends BaseModel
* @var string
*/
public $wallet;

/**
* Expiration time in seconds.
*
* @var integer
*/
public $expirationTimeInSeconds;
}
29 changes: 29 additions & 0 deletions src/Services/Adapters/DebitCardPaymentAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<?php
namespace Ebanx\Benjamin\Services\Adapters;


class DebitCardPaymentAdapter extends BrazilPaymentAdapter
{
protected function transformPayment()
{
$transformed = parent::transformPayment();
$transformed->payment_type_code = $this->payment->debit_card->type;
$transformed->card = $this->transformCard();
$transformed->manual_review = $this->payment->manualReview;

return $transformed;
}

private function transformCard()
{
return (object) [
'threeds_eci' => $this->payment->debit_card->threedsEci,
'threeds_cryptogram' => $this->payment->debit_card->threedsCryptogram,
'threeds_xid' => $this->payment->debit_card->threedsXid,
'threeds_version' => $this->payment->debit_card->threedsVersion,
'threeds_trxid' => $this->payment->debit_card->threedsTrxid,
'token' => $this->payment->debit_card->token
];
}

}
1 change: 1 addition & 0 deletions src/Services/Adapters/PaymentAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ protected function transformPayment()
'device_id' => $this->payment->deviceId,
'payment_type_code' => $this->payment->type,
'user_value_5' => 'Benjamin',
'expiration_time_in_seconds' => $this->payment->expirationTimeInSeconds,
];
if ($birthdate = $this->payment->person->birthdate) {
$payload['birth_date'] = $birthdate->format('d/m/Y');
Expand Down
6 changes: 3 additions & 3 deletions src/Services/Gateways/DebitCard.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
use Ebanx\Benjamin\Models\Country;
use Ebanx\Benjamin\Models\Currency;
use Ebanx\Benjamin\Models\Payment;
use Ebanx\Benjamin\Services\Adapters\CardPaymentAdapter;
use Ebanx\Benjamin\Services\Adapters\DebitCardPaymentAdapter;

class DebitCard extends DirectGateway
{
Expand Down Expand Up @@ -33,9 +33,9 @@ protected static function getEnabledCurrencies()

protected function getPaymentData(Payment $payment)
{
$payment->card->type = self::API_TYPE;
$payment->debit_card->type = self::API_TYPE;

$adapter = new CardPaymentAdapter($payment, $this->config);
$adapter = new DebitCardPaymentAdapter($payment, $this->config);
return $adapter->transform();
}
}
1 change: 1 addition & 0 deletions tests/Helpers/Builders/BuilderFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ private function setupFaker()
$this->faker->addProvider(new Providers\Item($this->faker));
$this->faker->addProvider(new Providers\Payment($this->faker));
$this->faker->addProvider(new Providers\Card($this->faker));
$this->faker->addProvider(new Providers\DebitCard($this->faker));
$this->faker->addProvider(new Providers\Request($this->faker));

$personProviderClass = $localProviderDir.'\Person';
Expand Down
16 changes: 14 additions & 2 deletions tests/Helpers/Builders/PaymentBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

use Ebanx\Benjamin\Models\Card;
use Ebanx\Benjamin\Models\Wallet;
use Ebanx\Benjamin\Models\DebitCard;
use Faker;
use Ebanx\Benjamin\Models\Bank;
use Ebanx\Benjamin\Models\Payment;
Expand Down Expand Up @@ -98,8 +99,19 @@ public function emptyCreditCard($instalmentNumber = 1)
public function debitCard()
{
$this->instance->type = 'debitcard';
$this->instance->card = $this->faker->cardModel();
$this->instance->card->number = '4242424242424242';
$this->instance->debit_card = $this->faker->debitCardModel();
$this->instance->debit_card->threeds_eci = '05';
$this->instance->debit_card->threeds_xid = 'AAIBAkl0NwmHglFBAXQ3AAAAAAA';
$this->instance->debit_card->threeds_version = '2';
$this->instance->debit_card->threeds_trxid = 'AAIBAkl0NwmHglFBAXQ3AAAAAAA';

return $this;
}

public function emptyDebitCard()
{
$this->instance->type = 'deditcard';
$this->instance->debit_card = new DebitCard();

return $this;
}
Expand Down
17 changes: 17 additions & 0 deletions tests/Helpers/Providers/DebitCard.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<?php
namespace Tests\Helpers\Providers;

use Ebanx\Benjamin\Models\DebitCard as DebitCardModel;

class DebitCard extends BaseProvider
{
/**
* @return \Ebanx\Benjamin\Models\DebitCard
*/
public function debitCardModel()
{
$card = new DebitCardModel();
$card->autoCapture = true;
return $card;
}
}
96 changes: 96 additions & 0 deletions tests/Unit/Services/Adapters/DebitCardPaymentAdapterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
<?php
namespace Tests\Unit\Services\Adapters;

use Ebanx\Benjamin\Services\Adapters\DebitCardPaymentAdapter;
use Tests\Helpers\Builders\BuilderFactory;
use JsonSchema;
use Ebanx\Benjamin\Models\Configs\Config;

class DebitCardPaymentAdapterTest extends PaymentAdapterTest
{
public function testJsonSchema()
{
$config = new Config([
'sandboxIntegrationKey' => 'testIntegrationKey'
]);
$factory = new BuilderFactory('pt_BR');
$payment = $factory->payment()->debitCard()->businessPerson()->build();

$adapter = new DebitCardPaymentAdapter($payment, $config);
$result = $adapter->transform();

$validator = new JsonSchema\Validator;
$validator->validate($result, $this->getSchema(['paymentSchema', 'brazilPaymentSchema', 'cardPaymentSchema']));

$this->assertTrue($validator->isValid(), $this->getJsonMessage($validator));
}


public function testAdaptEmptyCard()
{
$config = new Config([
'sandboxIntegrationKey' => 'testIntegrationKey'
]);
$factory = new BuilderFactory('pt_BR');
$payment = $factory->payment()->emptyDebitCard()->businessPerson()->build();

$adapter = new DebitCardPaymentAdapter($payment, $config);
$result = $adapter->transform();

$this->assertObjectHasAttribute('payment', $result);
}

public function testWithManualReview()
{
$config = new Config([
'sandboxIntegrationKey' => 'testIntegrationKey'
]);
$factory = new BuilderFactory('pt_BR');
$payment = $factory->payment()->debitCard()->businessPerson()->manualReview(true)->build();

$adapter = new DebitCardPaymentAdapter($payment, $config);
$result = $adapter->transform();

$this->assertObjectHasAttribute('payment', $result);
$this->assertObjectHasAttribute('manual_review', $result->payment);
$this->assertEquals(true, $result->payment->manual_review);
}

public function testWithoutManualReview()
{
$config = new Config([
'sandboxIntegrationKey' => 'testIntegrationKey'
]);
$factory = new BuilderFactory('pt_BR');
$payment = $factory->payment()->debitCard()->businessPerson()->build();

$adapter = new DebitCardPaymentAdapter($payment, $config);
$result = $adapter->transform();

$this->assertObjectHasAttribute('payment', $result);
$this->assertObjectHasAttribute('manual_review', $result->payment);
$this->assertEquals(null, $result->payment->manual_review);
}

public function testRequestAttributeNumber()
{
$config = new Config([
'sandboxIntegrationKey' => 'testIntegrationKey'
]);
$factory = new BuilderFactory('pt_BR');
$payment = $factory->payment()->emptyDebitCard()->businessPerson()->build();

$adapter = new DebitCardPaymentAdapter($payment, $config);
$result = $adapter->transform();

$numberOfKeys = count((array) $result);
$this->assertEquals(5, $numberOfKeys);
$this->assertObjectHasAttribute('integration_key', $result);
$this->assertObjectHasAttribute('operation', $result);
$this->assertObjectHasAttribute('mode', $result);
$this->assertObjectHasAttribute('metadata', $result);
$this->assertObjectHasAttribute('payment', $result);
}


}