Skip to content

[unitaryhack] feat: try-catch on plugin loading #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anushkrishnav wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[unitaryhack] feat: try-catch on plugin loading #545

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2744871
feat: try-catch on plugin loading
anushkrishnav Jun 11, 2022
5d9702a
updated try catch to throw and exception
anushkrishnav Jun 17, 2022
101c839
Update ServiceRegistry.cpp
anushkrishnav Jun 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion xacc/service/ServiceRegistry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,12 @@ void ServiceRegistry::initialize(const std::string rootPath) {
while ((ent2 = readdir(dir2)) != NULL) {
if (std::string(ent2->d_name).find("lib") != std::string::npos) {
// std::cout << "INSTALLING: " << path << "/" << std::string(ent2->d_name) << "\n";
try{
context.InstallBundles(path + "/" + std::string(ent2->d_name));
} catch (std::exception& e) {
XACCLogger::instance()->error("Error installing bundle: " + path + "/" + std::string(ent2->d_name));
}

}
}
closedir(dir2);
Expand All @@ -79,7 +84,7 @@ void ServiceRegistry::initialize(const std::string rootPath) {
try {
b.Start();
} catch (std::exception &e) {
xacc::error("Could not load " + b.GetSymbolicName() + ", error message: " + e.what());
xacc::warning("Could not load " + b.GetSymbolicName() + ", error message: " + e.what());
}
}

Expand Down