fix: define both prefer and requires for packages:all (#48)

* fix: define both prefer and requires for packages:all

* fix: packages:all:prefer does not allow any_of

* fix: package:all:prefer can use variants though

* fix: packages: acts: require: ~ipo

* fix: packages: dd4hep: %clang

* fix: packages: acts: default to +ipo again

* Clarify compiler requirement comment for dd4hep

Updated comment for clarity regarding compiler requirements.

* Grammar

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fix: packages: py-rich: require: @13:

* fix: packages: py-beautifulsoup4: require: @7.16:

* fix: packages: py-beautifulsoup4: require: @4.12:

* fix: packages: py-jupyterlab: require: @4.3.5:

* fix: packages: dd4hep: require: +edm4hep

* fix: {ci,xl}: packages: dd4hep: require: ~/+ddeve

* fix: {ci,xl}/epic: packages: geant4: require: ~/+opengl

* Disable fail-fast in build-push workflow

* fix: packages: llvm: require: ~ipo

LLVM 15.0.7 fails to build with IPO/LTO enabled. Disable it explicitly
to avoid compilation errors during the tf environment build.

Fixes build failure in job 6935933 where LLVM compilation failed,
causing py-llvmlite and py-numba to be skipped.

* fix: packages: llvm: use any_of for ~ipo requirement

The strict require: ~ipo was conflicting with packages:all:require when
llvm is used as an external package (found via spack external find).
Using any_of: [~ipo, '@:'] allows the requirement to be satisfied or
skipped when the variant is not applicable (e.g., for external packages).

This fixes the 'Only external, or concrete, compilers are allowed' error
during concretization.

* fix: py-hatchling: require: @1.27:

* fix: alphabetize packages requirements

* fix: clarify docs for packages: all: prefer vs require

Clarify comments regarding the prefer and require sections in packages.yaml.

* fix: packages: acts: require compiler from dd4hep

Updated dependencies and requirements for ACTS and dd4hep in packages.yaml.

* fix: syntax

* fix: syntax

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fix: openblas: require: build_system=makefile when +ilp64

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: wdconinc

.github/workflows/build-push.yml

@@ -107,6 +107,7 @@ jobs:
           PLATFORM: linux/amd64
           runner: ubuntu-latest
           arch: amd64
+      fail-fast: false
     steps:
       - name: Checkout 
         uses: actions/checkout@v4
@@ -406,6 +407,7 @@ jobs:
           runner: ubuntu-latest
           PLATFORM: linux/amd64
           target: builder_concretization_default
+      fail-fast: false
     steps:
       - name: Free Disk Space (Ubuntu)
         uses: jlumbroso/free-disk-space@v1.3.1

spack-environment/ci/epic/spack.yaml

@@ -5,6 +5,10 @@ spack:
   - ../../view.yaml
   include_concrete:
   - /opt/spack-environment/ci
+  packages:
+    geant4:
+      require:
+      - ~opengl
   specs:
   - algorithms
   - edm4eic

spack-environment/packages.yaml

@@ -11,6 +11,14 @@
 #
 packages:
   all:
+    # duplication between the prefer and require sections is intentional
+    # since 'require' for 'all' is overwritten by package-specific entries,
+    # and 'prefer' at least retains some (less strict) preference in that case
+    prefer:
+    - '%gcc'
+    - +ipo
+    - build_system=cmake
+    - build_type=Release
     require:
     - '%gcc'
     - any_of: [+ipo, '@:']
@@ -20,6 +28,11 @@ packages:
     require:
     - '@44.3.0'
     - cxxstd=20 +dd4hep ~edm4hep +examples +fatras +geant4 +json +onnx +podio +python +svg +tgeo +pr4496 +pr4502 +pr4620
+    # ACTS requires same compiler as DD4hep since compiler options are reused
+    - spec: '%gcc'
+      when: '^dd4hep%gcc'
+    - spec: '%clang'
+      when: '^dd4hep%clang'
   actsvg:
     require:
     - '@0.4.56'
@@ -96,9 +109,8 @@ packages:
     - '@1.16.2:'
   dd4hep:
     require:
-    - '%gcc'
     - '@1.33'
-    - +ddg4 +ddcad +hepmc3 +xercesc
+    - +ddg4 +ddcad +edm4hep +hepmc3 +xercesc
     - any_of: [+ddeve +utilityapps, -ddeve -utilityapps] # FIXME ^root +x +opengl when +utilityapps
   dpmjet:
     require:
@@ -254,6 +266,7 @@ packages:
   llvm:
     require:
     - ~gold
+    - any_of: [~ipo, '@:']
   madx:
     require:
     - '@5.08.01:'
@@ -287,6 +300,9 @@ packages:
   openblas:
     require:
     - ~fortran
+    - spec: build_system=makefile
+      when: +ilp64
+      # https://github.com/spack/spack-packages/pull/2890
   opencascade:
     require:
     - '@7.8.1:'
@@ -344,6 +360,9 @@ packages:
   py-awkward:
     require:
     - '@2.6.6:'
+  py-beautifulsoup4:
+    require:
+    - '@4.12:'
   py-bokeh:
     require:
     - '@3.5.2:'
@@ -359,6 +378,9 @@ packages:
   py-epic-capybara:
     require:
     - '@git.ef2a8790312b9b697655b28a07b353e601bfa3b8'
+  py-hatchling:
+    require:
+    - '@1.27:'
   py-hepunits:
     require:
     - '@2.3.2:'
@@ -369,6 +391,9 @@ packages:
   py-histoprint:
     require:
     - '@2.4.0:'
+  py-htgettoken:
+    require:
+    - '@1.16-33-g3788bb4'
   py-ipython:
     require:
     - '@8.28:'
@@ -381,25 +406,25 @@ packages:
   py-jsonschema:
     require:
     - +format-nongpl # non-default required for jupyter stack
+  py-jupyterlab:
+    require:
+    - '@4.3.5:'
   py-keras:
     require:
     - '@3.12:'
     - backend=tensorflow
-  py-lmfit:
-    require:
-    - '@1.0.2:'
   py-llvmlite:
     require:
     - '@0.44.0'
-  py-mplhep:
-    require:
-    - '@0.4.0:'
-  py-htgettoken:
+  py-lmfit:
     require:
-    - '@1.16-33-g3788bb4'
+    - '@1.0.2:'
   py-matplotlib:
     require:
     - '%clang' # https://github.com/spack/spack-packages/issues/1068
+  py-mplhep:
+    require:
+    - '@0.4.0:'
   py-nbformat:
     require:
     - '@5.8:' # avoid py-jupyter-server and snakemake divergence
@@ -439,6 +464,9 @@ packages:
   py-pyyaml:
     require:
     - '@6.0.2:'
+  py-rich:
+    require:
+    - '@13:'
   py-rucio-clients:
     require:
     - '@37.3.0:'

spack-environment/xl/epic/spack.yaml

@@ -7,6 +7,10 @@ spack:
   - /opt/spack-environment/xl
   concretizer:
     unify: when_possible # multiple epic versions
+  packages:
+    geant4:
+      require:
+      - +opengl
   specs:
   - algorithms
   - edm4eic