From 536a5f60dc07db1e2034a78155bd69a00d88a292 Mon Sep 17 00:00:00 2001 From: Timo K Date: Wed, 4 Feb 2026 19:55:49 +0100 Subject: [PATCH] small code comment fixups --- sdk/README.md | 2 +- src/livekit/openIDSFU.ts | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sdk/README.md b/sdk/README.md index 91337f109..25c0de283 100644 --- a/sdk/README.md +++ b/sdk/README.md @@ -21,7 +21,7 @@ in the repository root. It will create a `dist` folder containing the compiled js file. -This file needs to be hosted. Locally (via `npx serve -l 81234 --cors`) or on a remote server. +This file needs to be hosted. Locally (via `npx serve -l 1234 --cors`) or on a remote server. Now you just need to add the widget to element web via: diff --git a/src/livekit/openIDSFU.ts b/src/livekit/openIDSFU.ts index 0b7c2c784..e1aa72be1 100644 --- a/src/livekit/openIDSFU.ts +++ b/src/livekit/openIDSFU.ts @@ -78,8 +78,8 @@ export type OpenIDClientParts = Pick< * @param membership Our own membership identity parts used to send to jwt service. * @param serviceUrl The URL of the livekit SFU service * @param roomId The room id used in the jwt request. This is NOT the livekit_alias. The jwt service will provide the alias. It maps matrix room ids <-> Livekit aliases. - * @param opts Additional options to modify which endpoint with which data will be used to aquire the jwt token. - * @param opts.forceJwtEndpoint This will use the old jwt endpoint which will create the rtc backend identity based on string concatination + * @param opts Additional options to modify which endpoint with which data will be used to acquire the jwt token. + * @param opts.forceJwtEndpoint This will use the old jwt endpoint which will create the rtc backend identity based on string concatenation * instead of a hash. * This function by default uses whatever is possible with the current jwt service installed next to the SFU. * For remote connections this does not matter, since we will not publish there we can rely on the newest option. @@ -146,7 +146,7 @@ export async function getSFUConfigWithOpenID( } else { logger?.warn( `Failed fetching jwt with matrix 2.0 endpoint other issues ->`, - `(not going to try with legacy endpoint: forceOldJwtEndpoint is set to false, we did not get a not supported error from the sfu)`, + `(not going to try with legacy endpoint if forceMatrix2Jwt is set to false (it is ${forceMatrix2Jwt}), we did not get a not supported error from the sfu)`, e, ); // Make this throw a hard error in case we force the matrix2.0 endpoint.