Plans for Epiphany 44+?

[bobby285271]

Sorry if I am providing false positive here since NixOS does not start packaging GNOME 44 yet and all I say here are some guessing 💦

I think Epiphany 44 is ported to GTK4 and libadwaita, I installed org.gnome.Epiphany.Devel.flatpakref and it looks like it is using the Adwaita stylesheet instead of the elementary stylesheet. I assume when we package Epiphany 44 in Nixpkgs it should look the same way.

I personally prefer the app to use the elementary stylesheet on Pantheon desktop when possible. Is there some plan for elementary to do that? For example:

1. Do something conditionally using upstream's is_desktop_pantheon()
2. Use Gtk.Application instead of Adw.Application
3. ...

Or is there some suggestions on how we should take care of this in NixOS (we are shipping Epiphany on default Pantheon installations. we probably can't pin Epiphany to an old version specifically for Pantheon, but we can ship some Pantheon specific patches when needed as long as it is shipped by elementary and it applies cleanly on latest Epiphany - we are already doing that)?

[mcatanzaro]

CC @alatiera

[danirabbit]

I imagine for working around Adw.Application's stylesheet hardcoding that we'll need to carry a patch set, unless we can ask upstream for a conditional compile maybe? It's not something I've dived into just yet 😅

[mcatanzaro]

Why not just check if $XDG_CURRENT_DESKTOP contains Pantheon...?

[alice-mkh]

On libadwaita side? Because that would also contain Pantheon for other apps that aren't Epiphany or elementary apps using libadwaita.

[Marukesu]

@Exalm would be having a programmer-provided style manager possible? if so, we could have a Granite.StyleManager that epiphany can use.

otherwise, a explict adw_disable_styles() function would be the simple route, i think.

[alice-mkh]

@Exalm would be having a programmer-provided style manager possible? if so, we could have a Granite.StyleManager that epiphany can use.

That's already a non-issue. The issue is reliably detecting granite, see #browser on slack.

otherwise, a explict adw_disable_styles() function would be the simple route, i think.

Not happening, it's a "break me" option when used outside granite.

[alice-mkh]

Ephy side is up as well: https://gitlab.gnome.org/GNOME/epiphany/-/merge_requests/1292

[alice-mkh]

Ok, everything is merged - the latest nightly is using elementary styles.

Now there are a bunch of things to fix on your side:

• libadwaita disables its own icons in Granite compat mode, so you will need to provide the missing icons yourself

• there are tons of missing styles

.boxed-list, libadwaita rows, AdwPreferencesPage, AdwPreferencesGroup

GtkSearchBar

Listboxes inside popover.menu

A part of this one is an X11-specific gtk bug, but still missing AdwStatusPage styles.

Also note the missing spacing between the bookmarks and settings buttons - the rest of the buttons are in boxes with hardcoded spacing, but not these 2, so looks like header bars are missing spacing in general

Looks like there is some weird spacing between header bar and tab bar? At least in fullscreen

Header bar shadows end up behind content and can't really work here. We'll have a widget to make them work on libadwaita side in future, but obviously not for 44.

• the clipped labels in tabs are because of missing gtk-hint-font-metrics=1 - nothing I can do there, the clip bounds are correct on the libadwaita side

There are also missing styles upstream, e.g. checked state for reader mode icon or incognito styles. MRs welcome, though at this point they will be for 45.

[alice-mkh]

(Ignore the broken shadows on buttons - that's specific to the VM and it looks fine outside it here:

[danirabbit]

Fantastic work thank you! I’ll get those all fixed up for sure