Update to .NET 10 (#261)

* Update to .NET 10, fix Spectre.Console.Cli breaking changes and fix all warnings

* Improve null-safety across buffer commands and tasks

Removed `#nullable enable annotations` directives and updated
properties and parameters to be nullable where appropriate
(e.g., `FilePath?`, `Uri?`, `string?`) in buffer commands
(`BlueskyBufferCommand`, `FacebookBufferCommand`,
`LinkedInBufferCommand`, `MastodonBufferCommand`,
`TwitterBufferCommand`) and the `IContentTasks` interface.

Refactored `ContentTasks` methods (`BufferContentItemsAsync`,
`LoadContentItemsAsync`, `ShuffleBufferQueueAsync`) to handle
nullable values using null-safe operations, such as the
null-coalescing operator.

These changes enhance null-safety, reduce the risk of null
reference exceptions, and align with modern C# nullable
reference type practices.

* Bump major version

Author: HowardvanRooijen

.github/workflows/build.yml

@@ -55,7 +55,7 @@ jobs:
     needs: prepareConfig
     uses: endjin/Endjin.RecommendedPractices.GitHubActions/.github/workflows/scripted-build-pipeline.yml@main
     with:
-      netSdkVersion: '8.x'
+      netSdkVersion: '10.x'
       # workflow_dispatch inputs are always strings, the type property is just for the UI
       forcePublish: ${{ github.event.inputs.forcePublish == 'true' }}
       skipCleanup: ${{ github.event.inputs.skipCleanup == 'true' }}

.gitignore

@@ -403,3 +403,5 @@ FodyWeavers.xsd
 *.sbom*
 _codeCoverage/
 _packages/
+/.claude
+/.devcontainer

GitVersion.yml

@@ -20,5 +20,5 @@ branches:
     - feature
     - support
     - hotfix
-next-version: "1.0"
+next-version: "2.0"
 

Solutions/Stacker.Cli.Specs/Features/WordPressExportToTwitter.feature.cs

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net10.0</TargetFramework>
     <LangVersion>latest</LangVersion>
     <IsPackable>false</IsPackable>
     <IsTestProject>true</IsTestProject>
@@ -13,7 +13,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Corvus.Testing.ReqnRoll.NUnit" Version="4.0.3" />
+    <PackageReference Include="Corvus.Testing.ReqnRoll.NUnit" Version="4.0.5" />
   </ItemGroup>
 
   <ItemGroup>

Solutions/Stacker.Cli.Specs/Stacker.Cli.Specs.csproj

@@ -62,9 +62,9 @@ public async Task UploadAsync(IEnumerable<string> content, string profileId, boo
             if (!response.IsSuccessStatusCode)
             {
                 string errorContent = await response.Content.ReadAsStringAsync().ConfigureAwait(false);
-                BufferError error = JsonSerializer.Deserialize<BufferError>(errorContent);
+                BufferError? error = JsonSerializer.Deserialize<BufferError>(errorContent);
 
-                AnsiConsole.MarkupLineInterpolated($"[red]Buffering Failed:[/] {error.Message}");
+                AnsiConsole.MarkupLineInterpolated($"[red]Buffering Failed:[/] {error?.Message ?? "Unknown error"}");
                 AnsiConsole.WriteLine();
             }
         }
@@ -100,13 +100,13 @@ public async Task<BufferShuffleResponse> ShuffleAsync(string profileId, int? cou
 
         if (!response.IsSuccessStatusCode)
         {
-            BufferError error = JsonSerializer.Deserialize<BufferError>(content);
-            AnsiConsole.MarkupLineInterpolated($"[red]Shuffling Failed:[/] {error?.Message}");
+            BufferError? error = JsonSerializer.Deserialize<BufferError>(content);
+            AnsiConsole.MarkupLineInterpolated($"[red]Shuffling Failed:[/] {error?.Message ?? "Unknown error"}");
             AnsiConsole.WriteLine();
             return new BufferShuffleResponse { Success = false };
         }
 
-        BufferShuffleResponse result = JsonSerializer.Deserialize<BufferShuffleResponse>(content);
+        BufferShuffleResponse? result = JsonSerializer.Deserialize<BufferShuffleResponse>(content);
         AnsiConsole.MarkupLine("[chartreuse3_1]Shuffling completed successfully[/]");
 
         return result ?? new BufferShuffleResponse { Success = false };

Solutions/Stacker.Cli/BufferClient.cs

@@ -13,11 +13,11 @@ public class BufferError
     public bool Success { get; set; }
 
     [JsonPropertyName("message")]
-    public string Message { get; set; }
+    public string Message { get; set; } = string.Empty;
 
     [JsonPropertyName("code")]
     public int Code { get; set; }
 
     [JsonPropertyName("errored_profiles")]
-    public IEnumerable<Profiles> ErroredProfiles { get; set; }
+    public IEnumerable<Profiles> ErroredProfiles { get; set; } = [];
 }

Solutions/Stacker.Cli/BufferError.cs

@@ -5,8 +5,8 @@
 using System;
 using System.ComponentModel;
 using System.Diagnostics.CodeAnalysis;
+using System.Threading;
 using System.Threading.Tasks;
-
 using Spectre.Console.Cli;
 using Spectre.IO;
 
@@ -27,7 +27,7 @@ public BlueskyBufferCommand(IContentTasks contentTasks)
     }
 
     /// <inheritdoc/>
-    public override async Task<int> ExecuteAsync([NotNull] CommandContext context, [NotNull] Settings settings)
+    public override async Task<int> ExecuteAsync([NotNull] CommandContext context, [NotNull] Settings settings, CancellationToken cancellationToken)
     {
         await this.contentTasks.BufferContentItemsAsync<BlueskyFormatter>(
             settings.ContentFilePath,
@@ -50,23 +50,21 @@ await this.contentTasks.BufferContentItemsAsync<BlueskyFormatter>(
     /// </summary>
     public class Settings : CommandSettings
     {
-#nullable disable annotations
-
         [CommandOption("-c|--content-file-path")]
         [Description("Content file path.")]
-        public FilePath ContentFilePath { get; init; }
+        public FilePath? ContentFilePath { get; init; }
 
         [CommandOption("-h|--content-http-uri")]
         [Description("Content http uri.")]
-        public Uri ContentUri { get; init; }
+        public Uri? ContentUri { get; init; }
 
         [CommandOption("-n|--profile-name")]
         [Description("Twitter profile to Buffer.")]
-        public string ProfileName { get; init; }
+        public string? ProfileName { get; init; }
 
         [CommandOption("-g|--filter-by-tag")]
         [Description("Tag to filter the content items by.")]
-        public string FilterByTag { get; init; }
+        public string? FilterByTag { get; init; }
 
         [CommandOption("-i|--item-count")]
         [Description("Number of content items to buffer. If omitted all content is buffered.")]

Solutions/Stacker.Cli/Commands/BlueskyBufferCommand.cs

@@ -4,6 +4,7 @@
 
 using System.ComponentModel;
 using System.Diagnostics.CodeAnalysis;
+using System.Threading;
 using System.Threading.Tasks;
 
 using Spectre.Console.Cli;
@@ -24,7 +25,7 @@ public BufferShuffleCommand(IContentTasks contentTasks, string profile)
     }
 
     /// <inheritdoc/>
-    public override async Task<int> ExecuteAsync([NotNull] CommandContext context, [NotNull] Settings settings)
+    public override async Task<int> ExecuteAsync([NotNull] CommandContext context, [NotNull] Settings settings, CancellationToken cancellationToken)
     {
         BufferShuffleResponse result = await this.contentTasks.ShuffleBufferQueueAsync(
             this.profilePrefix,
@@ -41,7 +42,7 @@ public class Settings : CommandSettings
     {
         [CommandOption("-n|--profile-name")]
         [Description("Buffer profile name to shuffle.")]
-        public string ProfileName { get; init; }
+        public required string ProfileName { get; init; }
 
         [CommandOption("-c|--count")]
         [Description("Number of updates to shuffle. If omitted, all scheduled updates are shuffled.")]

Solutions/Stacker.Cli/Commands/BufferShuffleCommand.cs

@@ -2,9 +2,9 @@
 // Copyright (c) Endjin Limited. All rights reserved.
 // </copyright>
 
-#nullable enable annotations
-
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
+using System.Threading;
 
 using Spectre.Console;
 using Spectre.Console.Cli;
@@ -25,7 +25,7 @@ public EnvironmentInitCommand(IAppEnvironment appEnvironment, IStackerSettingsMa
         this.settingsManager = settingsManager;
     }
 
-    public override int Execute(CommandContext context)
+    public override int Execute([NotNull] CommandContext context, CancellationToken cancellationToken)
     {
         this.appEnvironment.Initialize();
         this.settingsManager.SaveSettings(
@@ -44,8 +44,10 @@ public override int Execute(CommandContext context)
                     {
                         Email = string.Empty,
                         IsActive = true,
+                        Twitter = string.Empty,
                     }
                 ],
+                WordPressToMarkdown = new WordPressToMarkdown(),
             },
             nameof(StackerSettings));