week3 solutions #26
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| const arr = (count = 0) => { | ||
| return new Array(count).fill(0).map((_, index) => index) | ||
| } | ||
|
|
||
| module.exports = { arr } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| const arr = require("./emin.index.js").arr | ||
|
|
||
| test("arr function exists", () => { | ||
| expect(arr).toBeDefined() | ||
| }) | ||
|
|
||
| test("return type is array", () => { | ||
| expect(Array.isArray(arr())).toEqual(true) | ||
| }) | ||
|
|
||
| describe("array elements", function () { | ||
| test("should get correct answer", function () { | ||
| expect(arr(6)).toEqual([0, 1, 2, 3, 4, 5]) | ||
| expect(arr(1)).toEqual([0]) | ||
| expect(arr(0)).toEqual([]) | ||
| }) | ||
| }) | ||
|
|
||
| describe("array length", function () { | ||
| test("should get correct answer", function () { | ||
| expect(arr(6).length).toEqual(6) | ||
| expect(arr(1).length).toEqual(1) | ||
| expect(arr(0).length).toEqual(0) | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| const get_score = (arr = [4, 2, 2, 3, 3, 4, 2]) => { | ||
| score = 0 | ||
| level = 0 | ||
| lineCounter = 0 | ||
| basePoints = [40, 100, 300, 1200] | ||
|
|
||
| for (let line of arr) { | ||
| score += basePoints[line - 1] * (level + 1) | ||
| lineCounter += line | ||
| if (lineCounter >= 10) { | ||
| lineCounter -= 10 | ||
| level++ | ||
| } | ||
| } | ||
| return score | ||
| } | ||
| get_score() | ||
|
|
||
| module.exports = { get_score } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| const get_score = require("./emin.index.js").get_score | ||
|
|
||
| test("get_score function exists", () => { | ||
| expect(get_score).toBeDefined() | ||
| }) | ||
|
|
||
| test("return type is number", () => { | ||
| expect(typeof get_score([])).toEqual("number") | ||
| }) | ||
|
|
||
| describe("scores", function () { | ||
| test("should get correct answer", function () { | ||
| expect(get_score([4, 2, 2, 3, 3, 4, 2])).toEqual(4900) | ||
| }) | ||
|
Collaborator
There was a problem hiding this comment. To be secure with your solution try adding several cases in your tests, especially the tricky ones. ; ) |
||
| }) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A very good and clean solution in general but it fails when the player doesn't clear any line and we have "0" in our input array. In the instructions, the input range is given from 0 to 4. You seem to have ignored the "0" part also in your tests. ; ) Can you please edit your function and push it again?