Open project from command line

[frontendwizard]

[eveningkid]

I truly have no idea how to do this. Do you have any leads?
Also, is this necessary at the moment?

[vaporwavie]

This is a good thing to have, as other code editors supports it (e.g code path/to/file/or/project). I'm not quite sure on how these things works on Mac, though.

[frontendwizard]

I found an article about that. I'll give it a try. Should the cli be called reacto? I feel like this would be good.

[eveningkid]

Sure, if you find any details about this and don't have time to implement it, share it there.
I can take care of it. :)
Let me know, so we can update this issue and make it available asap.

[frontendwizard]

yeah, I did found out that you can use the app binary as a cli by calling /Application/Reacto.app/Contents/MacOS/Reacto and then handling the arguments on the main.js as explained here: https://discuss.atom.io/t/bundle-a-cli-app-inside-the-electron-app/40113/2
I'll be putting some time on this approach today.

[frontendwizard]

https://github.com/atom/atom/blob/master/src/main-process/parse-command-line.js
atom deals with this using yargs

[eveningkid]

Really interesting approach. What are your thoughts on such a CLI helper for Reacto?

[frontendwizard]

I'm not really sure it is needed if we are doing only one thing without any options. But if we want this to a be a more complete solution and have more options, yargs is indeed a nice solution. Short story: we might not need now, but we'll surely need it later.

[frontendwizard]

Correction, right now it'd already be useful by parsing the options and showing the version when we type reacto -v.

[frontendwizard]

The only problem with this approach is that I don't really know how to test this in development. Do you have any ideas on how to test this without making a package?

[eveningkid]

If we only get the current version of Reacto, I don't think that a CLI is currently needed.
I guess you'll need to create a package even for testing. Simply set the bin attribute to where it should call the CLI from (quickly look this up this online, bin property of package.json). Your CLI will be just a node script I guess, right?

[frontendwizard]

Ok, I agree that we do not need many options for now. The cli effectively is the own binary. We gotta handle the call from cli by parsing process.argv on main.js and checking if there's more arguments on it. If there is, than we check if the argument is a directory (I guess we should also open single files...) and then load the directory through the filetree function.
Is it only my machine that takes like 20+ minutes to pack the application?

[eveningkid]

I think your approach is correct and could work. I just have no idea how to actually do all the communication between a running reacto instance and what we get from the command line.

If you feel like spending time on this, please do some experiments and share your results here. I think that at this point, this is the only way to actually get answers. Maybe it won't work, maybe it will, haha.

And usually, I stop the build process when it says something like building "maps" or something. So usually, as soon as it updated the .dmg file, it's all good. Why asking? Do you need to pack it every single time for testing? :o