From 4ca7d312ec878611840845378ede2a675c4d2fbc Mon Sep 17 00:00:00 2001 From: Gavin Ridley Date: Sat, 28 Oct 2023 19:34:38 -0400 Subject: [PATCH] fix overestimate of k in multiple gen per batch --- src/simulation.cpp | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/src/simulation.cpp b/src/simulation.cpp index dc598fdd19a..f4d94f5c805 100644 --- a/src/simulation.cpp +++ b/src/simulation.cpp @@ -783,13 +783,12 @@ void transport_history_based_device() transport_history_based_single_particle(p, absorption, collision, tracklength, leakage, need_depletion_rx); } - simulation::total_weight = total_weight; - // Write local reduction results to global values - global_tally_absorption = absorption; - global_tally_collision = collision; - global_tally_tracklength = tracklength; - global_tally_leakage = leakage; + global_tally_absorption += absorption; + global_tally_collision += collision; + global_tally_tracklength += tracklength; + global_tally_leakage += leakage; + simulation::total_weight += total_weight; // Copy back fission bank to host simulation::fission_bank.copy_device_to_host(); @@ -814,11 +813,11 @@ void transport_history_based() transport_history_based_single_particle(p, absorption, collision, tracklength, leakage, need_depletion_rx); } // Write local reduction results to global values - global_tally_absorption = absorption; - global_tally_collision = collision; - global_tally_tracklength = tracklength; - global_tally_leakage = leakage; - simulation::total_weight = total_weight; + global_tally_absorption += absorption; + global_tally_collision += collision; + global_tally_tracklength += tracklength; + global_tally_leakage += leakage; + simulation::total_weight += total_weight; } void transport_event_based()