Skip to content

Alpine aarch64 build questions #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Downchuck wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Alpine aarch64 build questions #1645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae1198a
lseek64 in raw_ostream.cpp
Downchuck Mar 9, 2025
47444ea
includes for implicit string include
Downchuck Mar 10, 2025
9b0bfde
capabilities annotation on std:mutex
Downchuck Mar 10, 2025
263778e
Update raw_ostream.cpp
Downchuck Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions API/hermes/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,9 @@ if(HERMES_THREAD_SAFETY_ANALYSIS)
AsyncDebuggerAPI.cpp
${CDP_API_SOURCES}
)
if("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang")
if("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang") # warning instead for struggle with std:mutex capabilities annotation
set_property(SOURCE ${TSA_SOURCES} APPEND_STRING PROPERTY
COMPILE_FLAGS "-Wthread-safety -Werror=thread-safety-analysis -Werror=thread-safety-precise -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS")
COMPILE_FLAGS "-Wthread-safety -Wthread-safety-analysis -Werror=thread-safety-precise -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS")
endif()
endif()

Expand Down
3 changes: 3 additions & 0 deletions API/hermes/cdp/DomainState.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
* LICENSE file in the root directory of this source tree.
*/

#include <string>
#include <functional>
#include <iostream>
#include "DomainState.h"

#include <cassert>
Expand Down
5 changes: 3 additions & 2 deletions external/llvh/lib/Support/raw_ostream.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -736,10 +736,11 @@ uint64_t raw_fd_ostream::seek(uint64_t off) {
flush();
#ifdef _WIN32
pos = ::_lseeki64(FD, off, SEEK_SET);
#elif defined(HAVE_LSEEK64)
# FIXME: https://reviews.llvm.org/D139752?id=484363
#elif defined(NOT_HAVE_LSEEK64)
pos = ::lseek64(FD, off, SEEK_SET);
#else
pos = ::lseek(FD, off, SEEK_SET);
pos = lseek(FD, off, SEEK_SET);
#endif
if (pos == (uint64_t)-1)
error_detected(std::error_code(errno, std::generic_category()));
Expand Down