Skip to content

Add defineConsts usage to benchmark #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mellyeliu merged 3 commits into from
Nov 5, 2025
Merged

Add defineConsts usage to benchmark #1312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b4123c
Add defineConsts tests
j-malt Oct 31, 2025
2f1b408
Add defineConsts to the benchmark
j-malt Oct 31, 2025
4c05759
Merge branch 'main' into jm-define-const-benchmark
j-malt Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 60 additions & 7 deletions packages/benchmarks/perf/fixtures/create-complex.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@
*/

import * as stylex from '@stylexjs/stylex';
import { sizes } from './sizes.stylex';

export const styles = stylex.create({
root: {
backgroundColor: 'transparent',
borderWidth: 0,
borderRadius: sizes.borderRadiusMedium,
color: {
default: 'inherit',
':hover': 'black',
Expand All @@ -19,9 +21,10 @@ export const styles = stylex.create({
display: 'inline-block',
fontFamily: 'inherit',
fontSize: 'inherit',
gap: sizes.gapSmall,
lineHeight: 'inherit',
margin: 0,
padding: 0,
margin: sizes.marginTiny,
padding: sizes.paddingTiny,
textAlign: 'inherit',
textDecoration: {
default: 'inherit',
Expand All @@ -38,12 +41,17 @@ export const styles = stylex.create({
},
wrapper: {
alignItems: 'center',
borderRadius: 4,
borderRadius: sizes.borderRadiusLarge,
display: 'flex',
gap: sizes.gapMedium,
height: 254,
justifyContent: 'center',
margin: sizes.marginSmall,
minHeight: 100,
overflow: 'hidden',
padding: sizes.paddingMedium,
paddingBlock: sizes.paddingLarge,
paddingInline: sizes.paddingSmall,
position: 'relative',
textAlign: 'center',
width: '100%',
Expand All @@ -52,6 +60,7 @@ export const styles = stylex.create({
},
},
button: {
borderRadius: sizes.borderRadiusMedium,
color: {
default: 'var(--blue-link)',
':hover': {
Expand All @@ -60,32 +69,73 @@ export const styles = stylex.create({
},
':active': 'scale(0.9)',
},
height: sizes.buttonHeightMedium,
padding: sizes.paddingSmall,
paddingBlock: sizes.paddingTiny,
paddingInline: sizes.paddingMedium,
},
buttonSmall: {
borderRadius: sizes.borderRadiusSmall,
height: sizes.buttonHeightSmall,
margin: sizes.marginTiny,
padding: sizes.paddingTiny,
paddingBlock: sizes.paddingTiny,
paddingInline: sizes.paddingSmall,
},
buttonLarge: {
borderRadius: sizes.borderRadiusLarge,
height: sizes.buttonHeightLarge,
margin: sizes.marginSmall,
padding: sizes.paddingLarge,
paddingBlock: sizes.paddingMedium,
paddingInline: sizes.paddingLarge,
},
linkUnderline: {
backgroundColor: 'var(--primary-button-background)',
borderTopEndRadius: 1,
borderTopStartRadius: 1,
borderTopEndRadius: sizes.borderRadiusSmall,
borderTopStartRadius: sizes.borderRadiusSmall,
bottom: 0,
end: 2,
end: sizes.paddingSmall,
height: 3,
margin: sizes.marginTiny,
padding: sizes.paddingTiny,
position: 'absolute',
start: 2,
start: sizes.paddingSmall,
transform: 'scaleY(0)',
transformOrigin: 'center bottom',
transitionDuration: 'var(--fds-fast)',
transitionProperty: 'transform',
transitionTimingFunction: 'var(--fds-soft)',
},
outerWithExpandedOnLargeScreensGlobalPanel: {
borderRadius: sizes.borderRadiusMedium,
gap: sizes.gapSmall,
insetInlineStart: {
default: 'var(--global-panel-width-expanded)',
'@media (max-width: 1200px)': 'var(--global-panel-width)',
},
margin: sizes.marginMedium,
padding: sizes.paddingMedium,
width: {
default: 'calc(100% - var(--global-panel-width-expanded))',
'@media (max-width: 1200px)': 'calc(100% - var(--global-panel-width))',
},
},
panel: {
borderRadius: sizes.borderRadiusLarge,
gap: sizes.gapMedium,
margin: sizes.marginLarge,
padding: sizes.paddingLarge,
paddingBlock: sizes.paddingMedium,
paddingInline: sizes.paddingLarge,
},
panelHeader: {
borderRadius: sizes.borderRadiusMedium,
gap: sizes.gapSmall,
margin: sizes.marginSmall,
marginBlockEnd: sizes.marginMedium,
padding: sizes.paddingMedium,
},
dynamicHeight: (height) => ({ height }),
dynamicPadding: (paddingTop, paddingBottom) => ({
paddingTop,
Expand All @@ -98,4 +148,7 @@ export const styles = stylex.create({
dynamicLetterSpacing: (letterSpacing) => ({ letterSpacing }),
dynamicTextTransform: (textTransform) => ({ textTransform }),
dynamicTextDecoration: (textDecoration) => ({ textDecoration }),
dynamicBorderRadius: (borderRadius) => ({ borderRadius }),
dynamicMargin: (margin) => ({ margin }),
dynamicGap: (gap) => ({ gap }),
});
42 changes: 42 additions & 0 deletions packages/benchmarks/perf/fixtures/sizes.stylex.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
import * as stylex from '@stylexjs/stylex';

const SemanticSizes = {
borderRadiusSmall: '0.25rem',
borderRadiusMedium: '0.5rem',
borderRadiusLarge: '0.75rem',
borderRadiusXLarge: '1rem',
paddingTiny: '0.25rem',
paddingSmall: '0.5rem',
paddingMedium: '1rem',
paddingLarge: '1.5rem',
paddingXLarge: '2rem',
marginTiny: '0.25rem',
marginSmall: '0.5rem',
marginMedium: '1rem',
marginLarge: '1.5rem',
marginXLarge: '2rem',
gapTiny: '0.25rem',
gapSmall: '0.5rem',
gapMedium: '1rem',
gapLarge: '1.5rem',
iconSizeSmall: '1rem',
iconSizeMedium: '1.5rem',
iconSizeLarge: '2rem',
buttonHeightSmall: '2rem',
buttonHeightMedium: '2.5rem',
buttonHeightLarge: '3rem',
inputHeightSmall: '2rem',
inputHeightMedium: '2.5rem',
inputHeightLarge: '3rem',
containerWidthSmall: '20rem',
containerWidthMedium: '40rem',
containerWidthLarge: '60rem',
};

export const sizes = stylex.defineConsts(SemanticSizes);