From 975dd5915c915633fce63dde42bb7214cae9e691 Mon Sep 17 00:00:00 2001 From: oblivionsage Date: Thu, 13 Nov 2025 02:58:41 +0100 Subject: [PATCH] wizard: fix incorrect variable usage in key image export In PageOTS_ExportKeyImages.cpp, the setupUR() function was exporting key images to a local variable 'ki_export' but then passing the uninitialized 'm_wizardFields->keyImages' to setData(). This resulted in the UR widget displaying empty data. Changed to export directly to m_wizardFields->keyImages, matching the pattern used in PageOTS_ExportOutputs.cpp::setupUR(). This also ensures the data is properly available when exportKeyImages() writes to file. Fixes TODO at PageOTS_ExportKeyImages.cpp:56 --- src/wizard/offline_tx_signing/PageOTS_ExportKeyImages.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/wizard/offline_tx_signing/PageOTS_ExportKeyImages.cpp b/src/wizard/offline_tx_signing/PageOTS_ExportKeyImages.cpp index 65002e93..56c264cb 100644 --- a/src/wizard/offline_tx_signing/PageOTS_ExportKeyImages.cpp +++ b/src/wizard/offline_tx_signing/PageOTS_ExportKeyImages.cpp @@ -53,9 +53,7 @@ void PageOTS_ExportKeyImages::exportKeyImages() { } void PageOTS_ExportKeyImages::setupUR(bool all) { - // TODO: check if empty - std::string ki_export; - m_wallet->exportKeyImagesToStr(ki_export, all); + m_wallet->exportKeyImagesToStr(m_wizardFields->keyImages, all); ui->widget_UR->setData("xmr-keyimage", m_wizardFields->keyImages); }