Skip to content

Use last_message_sequence over message_sequence in Firehose protocol #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bakkdoor wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use last_message_sequence over message_sequence in Firehose protocol #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/firehose/multiplexed_web_socket.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class MultiplexedWebSocket extends WebSocketTransport
@_sendMessage
multiplex_subscribe:
channel: channel
message_sequence: opts.last_sequence
last_message_sequence: opts.last_sequence

unsubscribe: (channelNames...) =>
@_sendMessage
Expand Down
6 changes: 3 additions & 3 deletions lib/firehose/web_socket_transport.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,10 @@ class WebSocketTransport extends Transport
@sendStartingMessageSequence @_lastMessageSequence
else @config.webSocket.connectionVerified @

sendStartingMessageSequence: (message_sequence) =>
@_lastMessageSequence = message_sequence
sendStartingMessageSequence: (last_message_sequence) =>
@_lastMessageSequence = last_message_sequence
@socket.onmessage = @_message
@_sendMessage({message_sequence})
@_sendMessage({last_message_sequence})
@_needToNotifyOfDisconnect = true
Transport::_open.call @

Expand Down