From a5fecfb90ea636c4e06128315c0f656ec8ffe2ba Mon Sep 17 00:00:00 2001 From: Jonas Bogenberger Date: Thu, 12 Dec 2024 17:09:04 +0100 Subject: [PATCH 1/3] rename function --- src/main/kotlin/assertk/assertions/inputstream.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/kotlin/assertk/assertions/inputstream.kt b/src/main/kotlin/assertk/assertions/inputstream.kt index af9f6cb4..80b0e7e4 100644 --- a/src/main/kotlin/assertk/assertions/inputstream.kt +++ b/src/main/kotlin/assertk/assertions/inputstream.kt @@ -48,7 +48,7 @@ private fun consume(stream: InputStream): Int { } } -private fun fillBuffer(stream: InputStream, buffer: ByteArray): Int { +private fun fillBufferFromStream(stream: InputStream, buffer: ByteArray): Int { var pos = 0 while (true) { From 7784a3b7b4007553ee3c57f4861824c2a897ee95 Mon Sep 17 00:00:00 2001 From: demo-user-112358 Date: Thu, 12 Dec 2024 17:37:28 +0100 Subject: [PATCH 2/3] change that will create a test gap --- src/main/kotlin/assertk/assertions/inputstream.kt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/main/kotlin/assertk/assertions/inputstream.kt b/src/main/kotlin/assertk/assertions/inputstream.kt index 80b0e7e4..a6523d0d 100644 --- a/src/main/kotlin/assertk/assertions/inputstream.kt +++ b/src/main/kotlin/assertk/assertions/inputstream.kt @@ -48,7 +48,7 @@ private fun consume(stream: InputStream): Int { } } -private fun fillBufferFromStream(stream: InputStream, buffer: ByteArray): Int { +private fun fillBuffer(stream: InputStream, buffer: ByteArray): Int { var pos = 0 while (true) { @@ -71,7 +71,7 @@ private fun doTheStreamHaveTheSameContent(actual: InputStream, expected: InputSt var size = 0L val actualBuffer = ByteArray(BUFFER_SIZE) - val otherBuffer = ByteArray(BUFFER_SIZE) + val someOtherBuffer = ByteArray(BUFFER_SIZE) while (true) { val actualRead = fillBuffer(actual, actualBuffer) @@ -134,6 +134,8 @@ private fun doTheStreamHaveTheSameContent(actual: InputStream, expected: InputSt throw IllegalStateException("unreachable code") } +private fun constFunction(): String = "Const Value" + private inline fun use(a: Closeable, b: Closeable, f: () -> R): R { return a.use { b.use { f() } } } From d495716cee0752746e33c24b2168176046c478bc Mon Sep 17 00:00:00 2001 From: demo-user-112358 Date: Thu, 12 Dec 2024 20:24:08 +0100 Subject: [PATCH 3/3] improve tests to close test gaps --- src/test/kotlin/test/assertk/assertions/InputStreamSpec.kt | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/test/kotlin/test/assertk/assertions/InputStreamSpec.kt b/src/test/kotlin/test/assertk/assertions/InputStreamSpec.kt index 46b522af..a3eafcd0 100644 --- a/src/test/kotlin/test/assertk/assertions/InputStreamSpec.kt +++ b/src/test/kotlin/test/assertk/assertions/InputStreamSpec.kt @@ -102,6 +102,13 @@ class InputStreamSpec : Spek({ assert(streamB()).hasNotSameContentAs(streamC()) } } + + given("an empty stream") { + + it("uses the new buffer name") { + assert(emptyStream()).hasSameContentAs(emptyStream()) + } + } })