From ff32d5890b7083e9570279430c83ff55b2de4644 Mon Sep 17 00:00:00 2001 From: Chris Hager Date: Fri, 23 Jan 2026 14:28:05 +0100 Subject: [PATCH] Claude PR review prompt improvement (more concise) --- .github/workflows/claude.yaml | 40 +++++++++++++++++------------------ 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/.github/workflows/claude.yaml b/.github/workflows/claude.yaml index 359acfa..a21cf17 100644 --- a/.github/workflows/claude.yaml +++ b/.github/workflows/claude.yaml @@ -22,7 +22,7 @@ jobs: if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v6 with: fetch-depth: 1 - uses: anthropics/claude-code-action@v1 @@ -36,20 +36,19 @@ jobs: REPO: ${{ github.repository }} PR NUMBER: ${{ github.event.pull_request.number }} - Act as a code reviewer for this pull request. Focus your review on: + Review this PR. Focus on: - Overall code quality and adherence to best practices - Possible bugs, edge cases, or logical errors - Security concerns or unsafe patterns - - Performance characteristics and potential optimizations + - Performance characteristics, issues and potential optimizations - Provide thorough, actionable feedback, and use inline comments for any line-specific issues you identify. + Be concise. Only comment on issues that need attention - no praise or positive comments. - Note: The PR branch is already checked out in the current working directory. - - Use `gh pr comment` for summary or top-level feedback on the PR. - Use `mcp__github_inline_comment__create_inline_comment` to annotate specific code issues inline. - Only post GitHub comments - don't submit review text as messages. - Use top-level comments for general observations or praise. + Notes: + - The PR branch is already checked out in the current working directory. + - Use `gh pr comment` for summary or top-level feedback on the PR. + - Use `mcp__github_inline_comment__create_inline_comment` to annotate specific code issues inline. + - Only use inline comments for problems, not praise. # Manual review triggered by "@claude review" comment (works for forks too) claude-manual-review: @@ -59,7 +58,7 @@ jobs: contains(github.event.comment.body, '@claude review') runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v6 with: fetch-depth: 1 - name: Checkout PR branch @@ -77,20 +76,19 @@ jobs: REPO: ${{ github.repository }} PR NUMBER: ${{ github.event.issue.number }} - Act as a code reviewer for this pull request. Focus your review on: + Review this PR. Focus on: - Overall code quality and adherence to best practices - Possible bugs, edge cases, or logical errors - Security concerns or unsafe patterns - - Performance characteristics and potential optimizations - - Provide thorough, actionable feedback, and use inline comments for any line-specific issues you identify. + - Performance characteristics, issues and potential optimizations - Note: The PR branch is already checked out in the current working directory. + Be concise. Only comment on issues that need attention - no praise or positive comments. - Use `gh pr comment` for summary or top-level feedback on the PR. - Use `mcp__github_inline_comment__create_inline_comment` to annotate specific code issues inline. - Only post GitHub comments - don't submit review text as messages. - Use top-level comments for general observations or praise. + Notes: + - The PR branch is already checked out in the current working directory. + - Use `gh pr comment` for summary or top-level feedback on the PR. + - Use `mcp__github_inline_comment__create_inline_comment` to annotate specific code issues inline. + - Only use inline comments for problems, not praise. # General interactive mode - responds to @claude mentions (but NOT review requests on PRs) claude-response: @@ -101,7 +99,7 @@ jobs: (github.event_name == 'issues' && (contains(github.event.issue.body, '@claude') || contains(github.event.issue.title, '@claude'))) runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v6 with: fetch-depth: 1 - name: Checkout PR branch (if on a PR)