Skip to content

Public method loadVideo not working. path argument missing. #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lujakob wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Public method loadVideo not working. path argument missing. #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ad7c7c
Add IDE .idea to gitignore.
lujakob Sep 18, 2016
a5aa858
Bugfix: Call public method loadVideo 'videoPath' argument not available.
lujakob Sep 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
videos/*
node_modules/*
css/main.css
build/*
build/*
.idea/*
6 changes: 4 additions & 2 deletions src/valiant.jquery.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,6 +507,8 @@ three.js r65 or higher
};

$.fn[pluginName] = function ( options ) {
// use pluginArguments instead of this.each arguments, otherwise Valiant360('loadVideo', 'path/to/video') path argument will be missing
var pluginArguments = arguments;
return this.each(function () {
if(typeof options === 'object' || !options) {
// A really lightweight plugin wrapper around the constructor,
Expand All @@ -516,8 +518,8 @@ three.js r65 or higher
$.data(this, "plugin_" + pluginName, this.plugin);
}
} else if(this.plugin[options]) {
// Allows plugin methods to be called
return this.plugin[options].apply(this.plugin, Array.prototype.slice.call(arguments, 1))
// Allows plugin methods to be called - use pluginArguments instead of this.each arguments
return this.plugin[options].apply(this.plugin, Array.prototype.slice.call(pluginArguments, 1))
}
});
};
Expand Down