Restoring an explicit frame name as part of loading a set is broken

[shipmints]

Related to #32. Reported by @pinaceaepinus.

bufferlo--bookmark-set-handler let binds bufferlo-bookmark-frame-load-make-frame to nil and this has the side effect of inhibiting new-frame-p in bufferlo--bookmark-frame-handler and prevents setting the embedded frame name. That logic needs some work.

[shipmints]

@pinaceaepinus, can you give the PR #49 a try and see if this resolves the issue with frame names and geometry when loading a set?

[pinaceaepinus]

@pinaceaepinus, can you give the PR #49 a try and see if this resolves the issue with frame names and geometry when loading a set?

As I haven't done something like this before: What's the right way to get emacs using the code from the PR?

Intuitively, I would clone the repo, switch to the changed file and M-x eval-buffer. In general this does not really scale and is error-prone, so what's the canonical way to let emac pick that code up?

[shipmints]

What I do is this:

mkdir ~/proj/shipmints-github/bufferlo
cd ~/proj/shipmints-github/
# this is where the branch lives until the PR is merged
git clone https://github.com/shipmints/bufferlo.git
git switch shipmints-restore-frame-specs-during-set-loading

(setq load-prefer-newer t) ; ensure elisp uses the most recent sources
(use-package bufferlo
  :demand t
  :load-path "~/proj/shipmints-github/bufferlo"
...
)

Obviously, you'll use whatever directory naming scheme you prefer.

[pinaceaepinus]

What I do is this:

mkdir ~/proj/shipmints-github/bufferlo
cd ~/proj/shipmints-github/

this is where the branch lives until the PR is merged

git clone https://github.com/shipmints/bufferlo.git
git switch shipmints-restore-frame-specs-during-set-loading

(setq load-prefer-newer t) ; ensure elisp uses the most recent sources
(use-package bufferlo
:demand t
:load-path "~/proj/shipmints-github/bufferlo"
...
)

Obviously, you'll use whatever directory naming scheme you prefer.

Good to know, thanks! :)

Now how does this here relate to #52 / shipmints-frame-handler-name-geometry-logic? Does it still makes sense to use the branch shipmints-restore-frame-specs-during-set-loading withouth the other fix?

[shipmints]

#53 supersedes #52 so take the branch above to try "shipmints-frame-handler-name-geometry-logic".

[pinaceaepinus]

Branch shipmints-frame-handler-name-geometry-logic works! Frame names are restored as desired.
Thank you! :)

[shipmints]

Thank you for testing. We will merge #53.

[pinaceaepinus]

Thank you for your effort and patience. :)