Skip to content

npm run lint fails with type warnings #257

@ryanbrainard

Description

@ryanbrainard

OS and version:
MacOS 11.3

VS Code Version:
chore/fix-prettier-issues (01d8d12)

SFDX CLI Version:
n/a

Summary

npm run lint fails with prettier errors.

Note, the lint problems in #254 are errors exiting 1, but these are the non-fatal warnings that remain after the fix in #255.

Steps To Reproduce:

  1. npm run lint

Expected result

No warnings and exit 0

Actual result

$ yarn run lint                                     
yarn run v1.22.10
$ lerna run lint
lerna notice cli v3.22.1
lerna info Executing command in 3 packages: "yarn run lint"
@salesforce/soql-common: $ eslint ./src
@salesforce/soql-model: $ eslint src/
@salesforce/soql-builder-ui: $ eslint ./src
@salesforce/soql-builder-ui: /Users/rbrainard/Development/soql-tooling/packages/soql-builder-ui/src/modules/querybuilder/app/app.ts
@salesforce/soql-builder-ui:   179:29  warning  Argument 'unsupported' should be typed  @typescript-eslint/explicit-module-boundary-types
@salesforce/soql-builder-ui:   192:29  warning  Argument 'e' should be typed            @typescript-eslint/explicit-module-boundary-types
@salesforce/soql-builder-ui:   207:30  warning  Argument 'e' should be typed            @typescript-eslint/explicit-module-boundary-types
@salesforce/soql-builder-ui:   212:32  warning  Argument 'e' should be typed            @typescript-eslint/explicit-module-boundary-types
@salesforce/soql-builder-ui:   215:31  warning  Argument 'e' should be typed            @typescript-eslint/explicit-module-boundary-types
@salesforce/soql-builder-ui:   219:29  warning  Argument 'e' should be typed            @typescript-eslint/explicit-module-boundary-types
@salesforce/soql-builder-ui:   223:31  warning  Argument 'e' should be typed            @typescript-eslint/explicit-module-boundary-types
@salesforce/soql-builder-ui:   226:31  warning  Argument 'e' should be typed            @typescript-eslint/explicit-module-boundary-types
@salesforce/soql-builder-ui:   229:37  warning  Argument 'e' should be typed            @typescript-eslint/explicit-module-boundary-types
@salesforce/soql-builder-ui: /Users/rbrainard/Development/soql-tooling/packages/soql-builder-ui/src/modules/querybuilder/fields/fields.ts
@salesforce/soql-builder-ui:   26:31  warning  Argument 'e' should be typed  @typescript-eslint/explicit-module-boundary-types
@salesforce/soql-builder-ui:   46:29  warning  Argument 'e' should be typed  @typescript-eslint/explicit-module-boundary-types
@salesforce/soql-builder-ui: /Users/rbrainard/Development/soql-tooling/packages/soql-builder-ui/src/modules/querybuilder/from/from.ts
@salesforce/soql-builder-ui:   28:33  warning  Argument 'e' should be typed  @typescript-eslint/explicit-module-boundary-types
@salesforce/soql-builder-ui: /Users/rbrainard/Development/soql-tooling/packages/soql-builder-ui/src/modules/querybuilder/limit/limit.ts
@salesforce/soql-builder-ui:   16:28  warning  Argument 'e' should be typed  @typescript-eslint/explicit-module-boundary-types
@salesforce/soql-builder-ui: /Users/rbrainard/Development/soql-tooling/packages/soql-builder-ui/src/modules/querybuilder/orderBy/orderBy.ts
@salesforce/soql-builder-ui:   24:32  warning  Argument 'e' should be typed  @typescript-eslint/explicit-module-boundary-types
@salesforce/soql-builder-ui:   47:31  warning  Argument 'e' should be typed  @typescript-eslint/explicit-module-boundary-types
@salesforce/soql-builder-ui: /Users/rbrainard/Development/soql-tooling/packages/soql-builder-ui/src/modules/querybuilder/services/sobjectUtils.ts
@salesforce/soql-builder-ui:   26:32  warning  Argument 'sobjectMetadata' should be typed with a non-any type  @typescript-eslint/explicit-module-boundary-types
@salesforce/soql-builder-ui: /Users/rbrainard/Development/soql-tooling/packages/soql-builder-ui/src/modules/querybuilder/where/where.ts
@salesforce/soql-builder-ui:   132:39  warning  Argument 'e' should be typed  @typescript-eslint/explicit-module-boundary-types
@salesforce/soql-builder-ui: /Users/rbrainard/Development/soql-tooling/packages/soql-builder-ui/src/modules/querybuilder/whereModifierGroup/whereModifierGroup.test.ts
@salesforce/soql-builder-ui:   122:3   warning  Skipped test                                                    jest/no-disabled-tests
@salesforce/soql-builder-ui:   281:41  warning  Using 'innerHTML/outputHTML/insertAdjacentHTML' is not allowed  @lwc/lwc/no-inner-html
@salesforce/soql-builder-ui:   560:45  warning  Using 'innerHTML/outputHTML/insertAdjacentHTML' is not allowed  @lwc/lwc/no-inner-html
@salesforce/soql-builder-ui:   578:45  warning  Using 'innerHTML/outputHTML/insertAdjacentHTML' is not allowed  @lwc/lwc/no-inner-html
@salesforce/soql-builder-ui:   596:45  warning  Using 'innerHTML/outputHTML/insertAdjacentHTML' is not allowed  @lwc/lwc/no-inner-html
@salesforce/soql-builder-ui:   614:45  warning  Using 'innerHTML/outputHTML/insertAdjacentHTML' is not allowed  @lwc/lwc/no-inner-html
@salesforce/soql-builder-ui: ✖ 23 problems (0 errors, 23 warnings)
lerna success run Ran npm script 'lint' in 3 packages in 16.1s:
lerna success - @salesforce/soql-builder-ui
lerna success - @salesforce/soql-common
lerna success - @salesforce/soql-model
✨  Done in 16.68s.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions