Improve delete handling

Author: Alexander Wirt

lib/Paste.pm

@@ -257,8 +257,12 @@ sub add_paste {
         $lang = $self->get_lang($lang);
         return 0 if $self->error;
     }
-    if ( $expire !~ /^(-1|[0-9]+)/ ) {
-        $self->{error} = "Expire must be an integer or -1";
+    
+    # Enforce 90 days max expiration (7776000 seconds)
+    my $max_expire = 7776000;
+    
+    if ( $expire !~ /^[0-9]+$/ || $expire > $max_expire ) {
+        $self->{error} = "Expire must be an integer <= $max_expire (90 days)";
         return 0;
     }
 

lib/Paste/App.pm

@@ -81,12 +81,21 @@ sub startup {
 
     $self->helper( paste_model   => sub { return $paste } );
     $self->helper( tt             => sub { return $tt } );
+
+    # Periodic cleanup (every hour)
+    Mojo::IOLoop->recurring(
+        3600 => sub {
+            $self->log->debug("Running scheduled paste cleanup...");
+            $paste->cleanup_expired;
+        }
+    );
+
     $self->helper(
         render_tt => sub {
             my ( $c, $template, $vars ) = @_;
             my $output = '';
             local %ENV = %{ $c->req->env };    # TT CGI plugin expects %ENV
-            $c->paste_model->cleanup_expired;
+            
             my $user_pastes = [];
             if ( $c->current_user ) {
                 my $sid = Digest::SHA::sha1_hex( $c->current_user->{id} );

templates/paste

@@ -26,7 +26,6 @@
 </select>
 <label for="expire"><b>Expiration</b></label>
 <select name="expire" id="expire">
-<option value="-1">Never</option>
 <option value="7776000">90d</option>
 <option value="259200">3d</option>
 <option value="86400" selected>24h</option>