Skip to content

Not distinguishing between group and individual addresses #6

@NickHibma

Description

@NickHibma

While studying the KNX protocol I was looking through your code and noticed that you do not distinguish between individual and group addressing. You do so in your debugging output, but not while handling telegrams.

Shouldn't you be checking the target address type bit before comparing against configured group addresses here?

if(IsAddressAssigned(telegram.GetTargetAddress(), addressedComObjectIndex))

It probably doesn't matter as this would only collide in installations with sufficient KNX modules, not your average hobby environment.

Thanks in any case for providing the code! Very interesting stuff!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions